Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Dark Theme? #3762

Closed
B-Reif opened this issue May 5, 2020 · 4 comments
Closed

[Docs] Dark Theme? #3762

B-Reif opened this issue May 5, 2020 · 4 comments
Labels

Comments

@B-Reif
Copy link
Contributor

B-Reif commented May 5, 2020

By default, docusaurus's classic theme provides a Dark mode. It looks like the Redux docusaurus config has explicitly disabled the dark mode.

It looks like Redux is already using the Docusaurus classic theme, with some custom styles. What would it take to enable the docusaurus dark mode?

@markerikson
Copy link
Contributor

There was some prior discussion on this when we transitioned to DS v2 for Redux Toolkit, with the conclusion that dark theme didn't mesh well for Redux's colors. See reduxjs/redux-toolkit#247 (comment) .

I'm not against having a dark theme, but I have no time to put into it myself and no expertise on that. My focus is on reworking our content.

If someone else can figure out what a reasonably correct set of dark theme colors would look like, we can look at getting that in, but it'll have to be a community-driven thing.

@timdorr
Copy link
Member

timdorr commented May 5, 2020

I think the version we started with had an incomplete version of it? If you want to make a PR to enable it, go right ahead.

@B-Reif
Copy link
Contributor Author

B-Reif commented May 5, 2020

I'll investigate. Is there a set of brand guidelines for Redux colors? Some of the custom css will have to change to maintain good contrast ratios. I'll try just lightening them for now.

@timdorr
Copy link
Member

timdorr commented May 5, 2020

Nope, it's always been made up as we go along. Whatever looks good :)

@B-Reif B-Reif closed this as completed May 6, 2020
alokreddy pushed a commit to alokreddy/redux that referenced this issue Sep 30, 2020
webMasterMrBin pushed a commit to webMasterMrBin/redux that referenced this issue Aug 21, 2021
webMasterMrBin pushed a commit to webMasterMrBin/redux that referenced this issue Aug 21, 2021
webMasterMrBin pushed a commit to webMasterMrBin/redux that referenced this issue Aug 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants