Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix false literal typo #2

Merged
merged 1 commit into from
Jul 5, 2015
Merged

fix false literal typo #2

merged 1 commit into from
Jul 5, 2015

Conversation

ryanatkn
Copy link
Contributor

@ryanatkn ryanatkn commented Jul 5, 2015

No description provided.

ellbee added a commit that referenced this pull request Jul 5, 2015
@ellbee ellbee merged commit fd22913 into reduxjs:master Jul 5, 2015
@ryanatkn
Copy link
Contributor Author

ryanatkn commented Jul 5, 2015

Looking at this again, the length comparison in argsEquals should never return false unless you mutate the selector array passed to createSelector. I think you can just remove that check - don't see why you would want to ever change the dependencies of a result function at runtime.

@ellbee
Copy link
Collaborator

ellbee commented Jul 6, 2015

@faassen I agree with ryanatkn, the length comparison check does look redundant here. What do you think?

@faassen
Copy link
Collaborator

faassen commented Jul 6, 2015

Ah, lost track of this one. Yes, I took a look at it and I agree. It'd be only be needed if this function was to be reused in other cases, but it's not so we're fine.

@faassen
Copy link
Collaborator

faassen commented Jul 6, 2015

This reminds me we should install some kind of coverage tool for the tests so we can find the original False spelling issue (my Python reflexes misleading me) more quickly. Does anyone know one we can integrate? I'll create an issue, see #5.

@faassen
Copy link
Collaborator

faassen commented Jul 7, 2015

If we change this one, how does this interact with hot loading, though? When you are doing hot loading it's possible for someone to change the signature of a selector. But would hot loading cause everything to be reloaded so we're okay, or would we have trouble with the cache having the old number of arguments?

@ellbee
Copy link
Collaborator

ellbee commented Jul 7, 2015

If the signature of a selector changes it means it has been edited, and therefore reloaded. So I don't think there should be a problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants