Use provided memoize options in outer memoize call

[montemishkin]

There are two memoize calls in createSelectorCreator. One is to memoize the so called resultFunc. The other memoize allows us to skip out early if the resulting selector is called with the exact same arguments.

Currently, this second memoize uses the caller's provided memoize implementation, but does not pass the caller's memoizeOptions. This PR changes it to pass the memoizeOptions.

[montemishkin]

its worth highlighting that this is a subtle change in behavior and could break dependent codebases. So bumping a version number seems to be in order

[codecov-io]

Codecov Report

Merging #359 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #359   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines          15     15           
=====================================
  Hits           15     15

Impacted Files	Coverage Δ
src/index.js	100% <100%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fda697a...f038cb2. Read the comment docs.

[PavelDemyanenko]

Any news on this request? Looks good to me

[Zhuvikin]

Faced the same issue. Is it planned to be merged?

[ms88privat]

I just investigated a related topic. I really think we should pass two memoize and two options to this selectorCreator, so everybody can decide what they want exactly. They should not depend on each other whatsoever. I was not happy when #297 was introduced. This forced me to do an expensive isEqual check on the broad input instead of the very lightweight outcome for the input of the result function. @ellbee What do you think about that?

[yoavniran]

facing the same issue exactly. passing memoizeOptions to the sub selectors makes a lot of sense, or at least being able to control this with a flag so it can be opt it

[oasisvali]

For those looking for a workaround in the meantime, I've found using the following pattern to be helpful:

const uniformMemoize = (func) => _.memoize(func, hashFn);

const createUniformMemoizeSelector = createSelectorCreator(
  uniformMemoize,
);

A nice side-effect of using this is that it unlocks the ability to use different memoization strategies for the overall selector arguments vs output function arguments. e.g.

// second argument only exists when the output function is memoized
const differentMemoize = (func, isOutput) => {
  if (isOutput) { return _.memoize(func, hashFn) }
  return defaultMemoize(func);
}

// this creates selectors with overall selector argument cache = defaultMemoize (cache size 1)
// output function argument cache = _.memoize w/ hashFn (cache size unlimited)
const differentMemoizeSelector = createSelectorCreator(
  differentMemoize,
  true,
);

[markerikson]

v5 allows separate memoize and argsMemoize customization options