Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional 4.1 tweaks based on existing PRs #514

Merged
merged 4 commits into from
Oct 20, 2021

Conversation

markerikson
Copy link
Contributor

This PR:

  • Adds an error message if resultFunc isn't a function
  • Improves the error message for bad dependency args
  • Includes memoizedResultFunc and lastResult in the util fields of the selector

Fixes #350
Fixes #404

Supersedes #358 , #359, #405 , #448 .

@codecov
Copy link

codecov bot commented Oct 20, 2021

Codecov Report

Merging #514 (c9a5207) into master (ee1500d) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #514   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           94       101    +7     
  Branches        21        24    +3     
=========================================
+ Hits            94       101    +7     
Impacted Files Coverage Δ
src/index.ts 100.00% <100.00%> (ø)

@RusinovAnton
Copy link

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants