Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug?]: Login Handler of dbAuth cannot handle case insensitive usernames #8676

Closed
1 task
dennemark opened this issue Jun 21, 2023 · 2 comments · Fixed by #8686
Closed
1 task

[Bug?]: Login Handler of dbAuth cannot handle case insensitive usernames #8676

dennemark opened this issue Jun 21, 2023 · 2 comments · Fixed by #8686
Labels
bug/needs-info More information is needed for reproduction

Comments

@dennemark
Copy link
Contributor

What's not working?

The following issue and PRs introduced feature to allow case insensitive usernames on signup
#7787
#7979
#8045

While it works for the signup handler, it does not work for Login.

@ageddesi mentioned he knows how to solve this, so I hope he can have a look at it :)

How do we reproduce the bug?

Using a redwoodjs project with standard dbAuth flow installed:

  • Signup for an account with case sensitive username (Ex: demoUser )
  • Log out, then log back in trying to use username in all lowercase (Ex: demouser)
  • Error: Could not find account with matching username

What's your environment? (If it applies)

No response

Are you interested in working on this?

  • I'm interested in working on this
@dennemark dennemark added the bug/needs-info More information is needed for reproduction label Jun 21, 2023
@ageddesi
Copy link
Contributor

I will get a PR in for this fix :)

@ageddesi ageddesi mentioned this issue Jul 6, 2023
Merged
@ageddesi
Copy link
Contributor

ageddesi commented Jul 6, 2023

PR Raised. <3

@Josh-Walker-GM Josh-Walker-GM linked a pull request Jul 6, 2023 that will close this issue
feature(#8676): added usernameMatch criteria to login methods to match signup #8686
Merged
jtoar pushed a commit that referenced this issue Jul 6, 2023
@ageddesi
feature(#8676): added usernameMatch criteria to login methods to matc…
f5d1a1a 
…h signup (#8686)

This PR adds insensitive matching to the login step of dbAuth, this is
to match the matching we implemented previously in the register step.
For full details please see the bug
#8676
jtoar pushed a commit that referenced this issue Jul 6, 2023
@ageddesi @jtoar
feature(#8676): added usernameMatch criteria to login methods to matc…
1631578 
…h signup (#8686)

This PR adds insensitive matching to the login step of dbAuth, this is
to match the matching we implemented previously in the register step.
For full details please see the bug
#8676
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug/needs-info More information is needed for reproduction
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feature(#8676): added usernameMatch criteria to login methods to match signup ageddesi/redwood
2 participants
@ageddesi @dennemark