feature(#8676): added usernameMatch criteria to login methods to match signup #8686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ageddesi
changed the title
ageddesi
changed the title
|
@cannikin Do you have time to review this one? I think you reviewed some of the prior related PRs? (The CI has some errors we're experiencing across various PRs so don't worry about those right now) |
cannikin
approved these changes
Jul 6, 2023
1 task
jtoar
pushed a commit
that referenced
this pull request
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds insensitive matching to the login step of dbAuth, this is to match the matching we implemented previously in the register step. For full details please see the bug #8676