fix(api-server): Preserve original host header for proxied API requests #10082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @magJ Thanks for taking the time to write and submit this PR! I'll pass it along for code review. 🙌 |
dac09
changed the title
dac09
approved these changes
Mar 7, 2024
jtoar
pushed a commit
that referenced
this pull request
Mar 7, 2024
…ts (#10082) Co-authored-by: Daniel Choudhury <dannychoudhury@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some apps rely on reading the host header(eg multi-tenant apps served over multiple subdomains).
The host header is no longer passed through after the API server was split from the web server.
Also vite doesn't pass through the host header when
changeOriginis true, which was fixed for development in #7811.This change preserves the host header for proxied fastify API requests.
It also extends the change made in #7811, to the new experimental streaming SSR server.
@dac09