Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency vite to v5 #10167

Closed
wants to merge 23 commits into from
Closed

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Mar 9, 2024

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
vite (source) 4.5.2 -> 5.1.5 age adoption passing confidence

Release Notes

vitejs/vite (vite)

v5.1.5

Compare Source

v5.1.4

Compare Source

v5.1.3

Compare Source

v5.1.2

Compare Source

v5.1.1

v5.1.0

v5.0.12

Compare Source

Please refer to CHANGELOG.md for details.

v5.0.11

Compare Source

v5.0.10

Compare Source

v5.0.9

Compare Source

v5.0.8

Compare Source

v5.0.7

Compare Source

v5.0.6

Compare Source

v5.0.5

Compare Source

v5.0.4

Compare Source

v5.0.3

Compare Source

v5.0.2

Compare Source

v5.0.1

v5.0.0


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@jtoar jtoar added this to the next-release milestone Mar 9, 2024
@jtoar jtoar added release:chore This PR is a chore (means nothing for users) fixture-ok Override the test project fixture check changesets-ok Override the changesets check labels Mar 9, 2024
Comment on lines -121 to +125
manifest: !env.ssrBuild ? 'client-build-manifest.json' : undefined,
manifest: !env.isSsrBuild ? 'client-build-manifest.json' : undefined,
// Note that sourcemap can be boolean or 'inline'
sourcemap: !env.ssrBuild && rwConfig.web.sourceMap,
sourcemap: !env.isSsrBuild && rwConfig.web.sourceMap,
rollupOptions: {
input: getRollupInput(!!env.ssrBuild),
input: getRollupInput(!!env.isSsrBuild),
Copy link
Contributor

@jtoar jtoar Mar 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One of the breaking changes; ssrBuild was renamed to isSsrBuild. See vitejs/vite#14855

Comment on lines +137 to +140
//
// Disable the new warning in Vite v5 about the CJS build being deprecated
// so that users don't have to see it when this command is called with --verbose
process.env.VITE_CJS_IGNORE_WARNING = 'true'
Copy link
Contributor

@jtoar jtoar Mar 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vite 5 deprecated the CJS api. The only place the CJS api is used is in a user's vite.config.ts file. We can disable the warning with https://github.com/vitejs/vite/blob/504bc5f80888ebd89d6c6726b18cb6f322ed538f/packages/vite/index.cjs#L29.

Comment on lines -41 to -43
legacy: {
// @MARK: for the worker, we're building ESM! (not CJS)
buildSsrCjsExternalHeuristics: false,
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is gone in Vite v5; see vitejs/vite#13816

@jtoar jtoar removed fixture-ok Override the test project fixture check changesets-ok Override the changesets check labels Mar 9, 2024
Copy link
Contributor Author

renovate bot commented Mar 9, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

jtoar added a commit that referenced this pull request Mar 9, 2024
It doesn't look like this config is necessary since we're only getting
the filenames, and I'm trying to isolate why CI is breaking in
#10167 so removing this here to
see if it matters.
jtoar added a commit that referenced this pull request Mar 11, 2024
This PR extracts out the non Vite v5 related changes from
#10167. That one is proving
difficult (the SSR smoke test keeps failing—`entry.server.mjs` isn't in
dist, but `entry.client.mjs` is 🤔) and I don't want some of these
changes to have to wait since they're unrelated.
@jtoar
Copy link
Contributor

jtoar commented Mar 11, 2024

Closing in favor of #10197.

@jtoar jtoar closed this Mar 11, 2024
@jtoar jtoar deleted the renovate/vite-5.x branch March 11, 2024 14:23
Copy link
Contributor Author

renovate bot commented Mar 11, 2024

Renovate Ignore Notification

Because you closed this PR without merging, Renovate will ignore this update. You will not get PRs for any future 5.x releases. But if you manually upgrade to 5.x then Renovate will re-enable minor and patch updates automatically.

If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR.

@jtoar jtoar removed this from the next-release milestone Mar 11, 2024
jtoar added a commit that referenced this pull request Mar 11, 2024
Redoing #10167 since I've split
out some of the changes in
#10196 and want a cleaner
commit history to debug CI.
jtoar added a commit that referenced this pull request Mar 12, 2024
Redoing #10167 since I've split
out some of the changes in
#10196 and want a cleaner
commit history to debug CI.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:chore This PR is a chore (means nothing for users)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant