Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rbac.md - code match #10405

Merged
merged 1 commit into from
Apr 10, 2024
Merged

Conversation

JamesHighsmith
Copy link
Contributor

code in repo was different from code in tutorial and it was missing the if statement. i added it in to reduce confusion for a new person who might get confused by the difference.

tutorial code:
Screen Shot 2024-04-03 at 12 06 55 PM

repo code:
Screen Shot 2024-04-03 at 12 07 34 PM

code in repo was different from code in tutorial and it was missing the if statement. i added it in to reduce confusion for a new person who might get confused by the difference.
@Josh-Walker-GM Josh-Walker-GM self-assigned this Apr 9, 2024
@Josh-Walker-GM Josh-Walker-GM added the release:fix This PR is a fix label Apr 9, 2024
@Josh-Walker-GM Josh-Walker-GM added this to the next-release-patch milestone Apr 9, 2024
Copy link
Collaborator

@Josh-Walker-GM Josh-Walker-GM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I agree it's helpful to make the docs consistent with what the user will actually see.

@Josh-Walker-GM Josh-Walker-GM added the changesets-ok Override the changesets check label Apr 9, 2024
@Josh-Walker-GM Josh-Walker-GM merged commit e6e1002 into redwoodjs:main Apr 10, 2024
50 of 54 checks passed
jtoar pushed a commit that referenced this pull request Apr 10, 2024
code in repo was different from code in tutorial and it was missing the
if statement. i added it in to reduce confusion for a new person who
might get confused by the difference.

tutorial code: 
![Screen Shot 2024-04-03 at 12 06 55
PM](https://github.com/redwoodjs/redwood/assets/2617706/4847d98a-5ed4-4e51-9cb6-ef6e91cac432)


repo code: 
![Screen Shot 2024-04-03 at 12 07 34
PM](https://github.com/redwoodjs/redwood/assets/2617706/210655e5-4ac5-434c-a08f-1a158566d3d9)
@jtoar jtoar modified the milestones: next-release-patch, v7.3.1 Apr 10, 2024
jtoar pushed a commit that referenced this pull request Apr 10, 2024
code in repo was different from code in tutorial and it was missing the
if statement. i added it in to reduce confusion for a new person who
might get confused by the difference.

tutorial code: 
![Screen Shot 2024-04-03 at 12 06 55
PM](https://github.com/redwoodjs/redwood/assets/2617706/4847d98a-5ed4-4e51-9cb6-ef6e91cac432)


repo code: 
![Screen Shot 2024-04-03 at 12 07 34
PM](https://github.com/redwoodjs/redwood/assets/2617706/210655e5-4ac5-434c-a08f-1a158566d3d9)
jtoar pushed a commit that referenced this pull request Apr 10, 2024
code in repo was different from code in tutorial and it was missing the
if statement. i added it in to reduce confusion for a new person who
might get confused by the difference.

tutorial code: 
![Screen Shot 2024-04-03 at 12 06 55
PM](https://github.com/redwoodjs/redwood/assets/2617706/4847d98a-5ed4-4e51-9cb6-ef6e91cac432)


repo code: 
![Screen Shot 2024-04-03 at 12 07 34
PM](https://github.com/redwoodjs/redwood/assets/2617706/210655e5-4ac5-434c-a08f-1a158566d3d9)
dac09 added a commit to dac09/redwood that referenced this pull request Apr 11, 2024
… into feat/og-gen-mw-vite-plugin

* 'feat/og-gen-mw-vite-plugin' of github.com:dac09/redwood:
  Update rbac.md - code match (redwoodjs#10405)
  chore: make crwa e2e test work across branches (redwoodjs#10437)
  feat: [Auth] Common AuthProvider & use* changes for middleware auth (redwoodjs#10420)
dac09 added a commit that referenced this pull request Apr 11, 2024
…th-mw-auth

* 'main' of github.com:redwoodjs/redwood: (21 commits)
  fix(auth): Handle when authorization header is lowercased (#10442)
  Update rbac.md - code match (#10405)
  chore: make crwa e2e test work across branches (#10437)
  feat: [Auth] Common AuthProvider & use* changes for middleware auth (#10420)
  fix(cli): only show webpack options for dev if `bundler = "webpack"` (#10359)
  fix(vercel): specify build env vars as a string (#10436)
  fix(vercel): write `vercel.json` as a part of setup (#10355)
  fix(middleware): Handle POST requests in middleware router too (#10418)
  chore(ci): get ci running on next (#10432)
  RSC: Explain noExternal vite config option (#10429)
  chore(web): Fix .d.ts overwrite build issue (#10431)
  chore(web): .js imports to prep for ESM (#10430)
  chore(refactor): Split rwjs/forms up into several smaller logical units (#10428)
  chore(rsc): simplify `noExternals` config (#10220)
  chore(deps): Update vite to 5.2.8 (#10427)
  chore(auth): Convert `@redwoodjs/auth` to ESM+CJS dual build (#10417)
  chore(framework-tools): Warn about missing metafile (#10426)
  chore(test): Switch rwjs/auth over to vitest (#10423)
  chore(whatwg-fetch): Switch to importing instead of requiring (#10424)
  chore(deps): bump undici from 5.28.3 to 5.28.4 in /.github/actions/check_changesets (#10421)
  ...
dac09 added a commit that referenced this pull request Apr 12, 2024
…g-gen-mw-p2

* 'main' of github.com:redwoodjs/redwood:
  feat(og-gen): Adds package and vite plugin for dynamic og generation (#10439)
  chore(deps): bump browserify-sign from 4.2.1 to 4.2.3 (#10446)
  chore(deps): bump tar from 6.1.11 to 6.2.1 in /docs (#10438)
  chore(deps): update dependency firebase to v10.11.0 (#10366)
  fix(auth): Handle when authorization header is lowercased (#10442)
  Update rbac.md - code match (#10405)
  chore: make crwa e2e test work across branches (#10437)
  feat: [Auth] Common AuthProvider & use* changes for middleware auth (#10420)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changesets-ok Override the changesets check release:fix This PR is a fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants