Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tests): Fix packages/web tests #10517

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

Tobbe
Copy link
Member

@Tobbe Tobbe commented Apr 26, 2024

React 19 changed the Symbol name it uses for standard html elements. The Jest pretty printer uses react-it to figure out how to convert JSX to a string for comparisons in tests. So we have to put a resolution in place for react-it to get a version that's updated to also work with the new React 19 symbol name

@Tobbe Tobbe changed the title react-is 19-canary chore(tests): Fix packages/web tests Apr 26, 2024
@Tobbe Tobbe added the release:chore This PR is a chore (means nothing for users) label Apr 26, 2024
@Tobbe Tobbe added this to the RSC milestone Apr 26, 2024
@Tobbe Tobbe added the changesets-ok Override the changesets check label Apr 26, 2024
@Tobbe Tobbe merged commit 771d8ef into redwoodjs:main Apr 26, 2024
50 of 56 checks passed
@Tobbe Tobbe deleted the tobbe-react-is-19-canary branch April 26, 2024 07:46
dac09 added a commit that referenced this pull request Apr 26, 2024
…g-gen-mw-p2

* 'main' of github.com:redwoodjs/redwood:
  RSC: Add RSC+SSR smoke test to CI (#10477)
  fix(dbauth-mw): Use response passed in to middleware (#10516)
  Add redwood.toml to `yarn rw info` (#10518)
  chore(tests): Fix packages/web tests (#10517)
  fix(dbauth-mw): Unset cookie instead of clearing (#10502)
  chore(deps): Upgrade to React canary 20240424 (#10513)
  chore(deps): Upgrade to React Testing Library 14.3.1 (#10514)
  feat(upgrade): Use GitHub token if available when downloading patches (#10515)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changesets-ok Override the changesets check release:chore This PR is a chore (means nothing for users)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant