-
Notifications
You must be signed in to change notification settings - Fork 975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds signup() to Auth to default UI to a signup tab/form when available #1057
Merged
peterp
merged 16 commits into
redwoodjs:main
from
dthyresson:dt-auth-provider-signup-963
Sep 7, 2020
Merged
Adds signup() to Auth to default UI to a signup tab/form when available #1057
peterp
merged 16 commits into
redwoodjs:main
from
dthyresson:dt-auth-provider-signup-963
Sep 7, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cb7417c
to
b076525
Compare
9e8a715
to
ad72738
Compare
This was referenced Sep 3, 2020
Bumps [eslint-plugin-react-hooks](https://github.com/facebook/react/tree/HEAD/packages/eslint-plugin-react-hooks) from 3.0.0 to 4.1.0. - [Release notes](https://github.com/facebook/react/releases) - [Changelog](https://github.com/facebook/react/blob/master/packages/eslint-plugin-react-hooks/CHANGELOG.md) - [Commits](https://github.com/facebook/react/commits/HEAD/packages/eslint-plugin-react-hooks) Signed-off-by: dependabot[bot] <support@github.com>
Bumps [graphql](https://github.com/graphql/graphql-js) from 14.7.0 to 15.3.0. - [Release notes](https://github.com/graphql/graphql-js/releases) - [Commits](graphql/graphql-js@v14.7.0...v15.3.0) Signed-off-by: dependabot[bot] <support@github.com>
Hmmmm... I wonder what happened with the commits here. |
peterp
reviewed
Sep 7, 2020
peterp
reviewed
Sep 7, 2020
peterp
approved these changes
Sep 7, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The any case covers void as well in signup method Co-authored-by: Peter Pistorius <peter.pistorius@gmail.com>
Whoop whoop thanks @dthyresson ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue: #963
Adds:
Note: Firebase will eventually need to support specifying he provider (Twitter, Apple, Facebook, Firebase, etc). But then the login and signup will also have to handle different cases and even scopes.
Also, for Auth0, if you want to use the useAuth hook
Sign Up
to default the UI to the sign up "tab", you need to be using the "New Universal Login Experience". The "Classic Universal Experience" does not support thescreen_hint
to set the tab.Auth Playground PR exists to test once PR is available in a canary release.