-
Notifications
You must be signed in to change notification settings - Fork 970
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): update dependency redis to v4.6.14 #10610
Conversation
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
@@ -36,7 +36,7 @@ export default class RedisClient extends BaseClient { | |||
(err: Error) => this.logger?.error(err) || console.error(err), | |||
) | |||
|
|||
return this.client.connect() | |||
await this.client.connect() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cannikin Just retroactively confirming I haven't done something stupid here and that this a fine change?
For context the BaseClient
class requires the connect
function to return void, either sync or async.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huh...so previously the connect() was sync and now it's not? Or should this have always had an await
here?
Think it's okay to drop the return
? Does it hurt to keep it in there along with the await
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The return had to go because the function returns void. Then I still have to await the call so that it's settled within the function. The connect function was already async. It no longer returns a promise but settles it internally - since it's not allowed to return it.
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [redis](https://togithub.com/redis/node-redis) | [`4.6.7` -> `4.6.14`](https://renovatebot.com/diffs/npm/redis/4.6.7/4.6.14) | [![age](https://developer.mend.io/api/mc/badges/age/npm/redis/4.6.14?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/redis/4.6.14?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/redis/4.6.7/4.6.14?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/redis/4.6.7/4.6.14?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>redis/node-redis (redis)</summary> ### [`v4.6.14`](https://togithub.com/redis/node-redis/releases/tag/redis%404.6.14) [Compare Source](https://togithub.com/redis/node-redis/compare/redis@4.6.13...redis@4.6.14) #### Enhancements - Upgrade `@redis/client` from `1.5.14` to `1.5.16` ### [`v4.6.13`](https://togithub.com/redis/node-redis/releases/tag/redis%404.6.13) [Compare Source](https://togithub.com/redis/node-redis/compare/redis@4.6.12...redis@4.6.13) #### Enhancements - Upgrade `@redis/client` from `1.5.13` to `1.5.14` ### [`v4.6.12`](https://togithub.com/redis/node-redis/releases/tag/redis%404.6.12) [Compare Source](https://togithub.com/redis/node-redis/compare/redis@4.6.11...redis@4.6.12) #### Enhancements - Upgrade `@redis/client` from ` 1.5.121 to `1.5.13\` ### [`v4.6.11`](https://togithub.com/redis/node-redis/releases/tag/redis%404.6.11) [Compare Source](https://togithub.com/redis/node-redis/compare/redis@4.6.10...redis@4.6.11) ##### Enhancements - Upgrade `@redis/client` from `1.5.11` to `1.5.12` - Upgrade `@redis/graph` from `1.1.0` to `1.1.1` - Upgrade `@redis/json` from `1.1.5` to `1.1.6` ### [`v4.6.10`](https://togithub.com/redis/node-redis/releases/tag/redis%404.6.10) [Compare Source](https://togithub.com/redis/node-redis/compare/redis@4.6.9...redis@4.6.10) #### Fixes - Revert the minimum node version change - Upgrade `@redis/client` from `1.5.9` to `1.5.10` - Upgrade `@redis/search` from `1.1.3` to `1.1.4` - Upgrade `@redis/json` from `1.0.4` to `1.0.5` ### [`v4.6.9`](https://togithub.com/redis/node-redis/releases/tag/redis%404.6.9) [Compare Source](https://togithub.com/redis/node-redis/compare/redis@4.6.8...redis@4.6.9) #### Enhancements - Upgrade `@redis/client` from `1.5.9` to `1.5.10` - Upgrade `@redis/search` from `1.1.3` to `1.1.4` - Upgrade `@redis/json` from `1.0.4` to `1.0.5` ### [`v4.6.8`](https://togithub.com/redis/node-redis/releases/tag/redis%404.6.8) [Compare Source](https://togithub.com/redis/node-redis/compare/redis@4.6.7...redis@4.6.8) #### Enhancements - upgrade `@redis/client` from `1.5.8` to `1.5.9` - upgrade `@redis/time-series` from `1.0.4` to `1.0.5` </details> --- ### Configuration π **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). π¦ **Automerge**: Enabled. β» **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. π **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/redwoodjs/redwood). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNjMuNSIsInVwZGF0ZWRJblZlciI6IjM3LjM2My41IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Josh GM Walker <56300765+Josh-Walker-GM@users.noreply.github.com>
This PR contains the following updates:
4.6.7
->4.6.14
Release Notes
redis/node-redis (redis)
v4.6.14
Compare Source
Enhancements
@redis/client
from1.5.14
to1.5.16
v4.6.13
Compare Source
Enhancements
@redis/client
from1.5.13
to1.5.14
v4.6.12
Compare Source
Enhancements
@redis/client
from1.5.121 to
1.5.13`v4.6.11
Compare Source
Enhancements
@redis/client
from1.5.11
to1.5.12
@redis/graph
from1.1.0
to1.1.1
@redis/json
from1.1.5
to1.1.6
v4.6.10
Compare Source
Fixes
@redis/client
from1.5.9
to1.5.10
@redis/search
from1.1.3
to1.1.4
@redis/json
from1.0.4
to1.0.5
v4.6.9
Compare Source
Enhancements
@redis/client
from1.5.9
to1.5.10
@redis/search
from1.1.3
to1.1.4
@redis/json
from1.0.4
to1.0.5
v4.6.8
Compare Source
Enhancements
@redis/client
from1.5.8
to1.5.9
@redis/time-series
from1.0.4
to1.0.5
Configuration
π Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
π¦ Automerge: Enabled.
β» Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
π Ignore: Close this PR and you won't be reminded about these updates again.
This PR has been generated by Mend Renovate. View repository job log here.