Use Replay for smoke tests #10664
Merged
Use Replay for smoke tests #10664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
callingmedic911
force-pushed
the
aditya/add-replay-to-smoke-tests
branch
from
36c2e77
to
4e2fc84
Compare
|
callingmedic911
force-pushed
the
aditya/add-replay-to-smoke-tests
branch
6 times, most recently
from
5800c77
to
89179e5
Compare
callingmedic911
added
the
release:chore
callingmedic911
force-pushed
the
aditya/add-replay-to-smoke-tests
branch
6 times, most recently
from
c2595c2
to
8b84e98
Compare
|
@callingmedic911 Thanks for opening this PR! ... I know it's still in Draft mode, but I wanted to go ahead and point out that one of the things that we've been paying careful attention to with Replay in our repo is speed. So, as you're working on this, would you mind to pay special attention to that? ❤️ |
|
@ahaywood Hello! Do you mean the speed of CI runs here? Or the performance of the framework? Replay adds very little overhead for recording. As for the latter, Replay is soon shipping Performance Analysis, which would be really useful in finding performance regression in the framework. |
callingmedic911
force-pushed
the
aditya/add-replay-to-smoke-tests
branch
4 times, most recently
from
26c3c61
to
218e84a
Compare
callingmedic911
force-pushed
the
aditya/add-replay-to-smoke-tests
branch
from
218e84a
to
a0044eb
Compare
|
@dac09 followup on our "failing test on Replay" discussion: I have filed an issue internally and as a workaround, I'm running that test on Chromium instead. I tagged you guys because you have the most context, but feel free to pass and / or ask questions. :) |
|
@callingmedic911 I'm going to rope @Tobbe in to help provide additional context. |
|
@callingmedic911 Thanks for doing all the work of integrating Replay with our smoke tests |
|
I think we need to add the API keys! Getting failures on other PRs |
|
Weird. I added that last week
|
dac09
added a commit
to dac09/redwood
that referenced
this pull request
May 30, 2024
…into feat/location-serverStore * 'feat/location-serverStore' of github.com:dac09/redwood: no need to repeat fullUrl Use Replay for smoke tests (redwoodjs#10664) chore(testing): Remove unused member in Props interface (redwoodjs#10699) fix(cli): Directive generator command was not creating files (redwoodjs#10698) Always execute the <Metadata> component on the client (redwoodjs#10271)
|
Looking into it. |
Josh-Walker-GM
pushed a commit
that referenced
this pull request
May 30, 2024
Tobbe
added a commit
to Tobbe/redwood
that referenced
this pull request
May 31, 2024
This reverts commit 14d9535.
Tobbe
added a commit
that referenced
this pull request
May 31, 2024
Josh-Walker-GM
pushed a commit
that referenced
this pull request
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR set up Replay for smoke tests. Dom integrated Replay in the past to debug hard-to-repro problems. There have been a lot of updates with Replay (Chromium instead of Firefox as base, new test suite dashboard, new CLI). Eventually, I want to set up Playwright (with Replay) for framework users but first for framework authors (you guys).
How do I access the Replay dashboard?
Dashboard home for RedwoodJS
How does the dashboard look?
Can you show me how you debug with Replay?
https://www.loom.com/share/6553abcaaaac489f999547cb76773134 (very rushed, tiny demo). Docs is also a good place to start: https://docs.replay.io/ (We rewrote that recently)
Other things to note: