Support Azure AD authentication: Implementation #1311

jeliasson · 2020-10-08T18:54:40Z

This PR seeks to implement Azure AD as authentication in the @redwoodjs/auth package.

See #1310

Brining up to speed

packages/api/src/auth/decoders/azureAd.ts

packages/api/src/auth/decoders/index.ts

packages/cli/src/commands/generate/auth/templates/azureAd.auth.js.template

peterp · 2020-10-29T12:57:54Z

@jeliasson You've done amazing work here, thanks @dthyresson for reviewing this :)

…djs-main

jeliasson · 2020-11-08T20:27:49Z

Hey all 🖐

@dthyresson I have implemented token validation (using Auth0 decoder example, thanks for pointing me in that direction!) and a better auth template for Azure Active Directory which picks up the roles nicely. By any chance you can have another review at your convenience? 🙏

@thedavidprice By any chance you can estimate time on the setup command and migration from generate as of #1307 #1309? Also, is there any chance to maybe merge this into a canary release? I'm about to start a new project based of Redwood, and that project will require this authentication method. Would like to target that canary release and do battle tests 😊

Latest documentation can be seen on this preview. Will need some more work tho.

Finally, is there any (long-term) "strategy" what various token claims that should be surfaced to currentUser? In the auth generator I bring in everything from ...decoded and adding email from decoded.prefered_username. Thoughts on this?

/cc @peterp

Tobbe · 2020-11-09T10:15:35Z

@jeliasson I'm sure @thedavidprice wouldn't mind some help with #1307 and #1309. If you want to jump in and do some work on those I'd be happy to review/merge to give you a canary to try 🙂

jeliasson · 2020-11-09T10:33:19Z

I'm sure @thedavidprice wouldn't mind some help with #1307 and #1309. If you want to jump in and do some work on those I'd be happy to review/merge to give you a canary to try 🙂

@Tobbe Unfortunately I'm swamped with work this month, otherwise I would catch up on those and jump right in. I would like to focus on the authentication, test in a real-life application from a canary, and I'll be happy to contribute to setup in December. 📌

If canary is not possible, is there any nice way of patching something under node_modules? I.e. manually bring in the changes. This would help greatly in the project I'm about to spin up. Thanks!

Tobbe · 2020-11-09T11:12:20Z

If canary is not possible, is there any nice way of patching something under node_modules? I.e. manually bring in the changes. This would help greatly in the project I'm about to spin up. Thanks!

@jeliasson You could voice your support for the issue I just created 🙂 #1458

github-actions · 2020-11-25T08:58:11Z

Install locally with yarn, e.g. yarn workspace web add <url>

andrew-hwahin · 2020-11-25T09:34:53Z

Hope this will be released soon😁🙏🙇‍♂️

Tobbe

Now that I've worked with this code (#1536) I feel I can read this and provide some feedback. Mostly nitpicking comments, but since you'll need to handle merging this with the new Supabase stuff anyway, I figured you could take a look at my minor comments as well.

Another thing you could do, that I forgot when I did the Supabase stuff, is update the comment at the end of the auth README, with the list of auth providers (please add Supabase as well if you do 🙂)

If you fix the comments and rebase your code I'll make sure we get this merged. No need to wait for @thedavidprice's setup stuff. We can move this over to setup later together with every other auth generator.

packages/api/src/auth/decoders/azureActiveDirectory.ts

packages/auth/src/authClients/azureActiveDirectory.ts

Co-authored-by: Tobbe Lundberg <tobbe@tlundberg.com>

…wood into feat/auth-azure-ad

Co-authored-by: Tobbe Lundberg <tobbe@tlundberg.com>

No method that corresponds with this in MSAL's UserAgentApplication class https://pub.dev/documentation/msal_js/latest/msal_js/UserAgentApplication-class.html#constructors

jeliasson · 2020-12-03T22:46:55Z

Thanks for the help @Tobbe and @dthyresson! ❤️

I'll bring in the canary release to redwoodjs/playground-auth#6 for final testing, and have another glance on the documentation in https://github.com/redwoodjs/redwoodjs.com/pull/407.

/ping @andrew-hwahin @AndrewLamYW

AndrewLamYW · 2020-12-04T00:43:34Z

Million thanks for the effort!🙏❤️ @jeliasson @Tobbe @dthyresson

I think this will definitely drives more RedwoodJS adoption for projects which has the requirement to use AzureAD.

jeliasson added 2 commits October 8, 2020 16:36

Merge pull request #1 from redwoodjs/main

6d23f98

Brining up to speed

Addinig initial implementation of Azure AD authentication

37beb7d

jeliasson mentioned this pull request Oct 8, 2020

Support Azure AD authentication #1310

Closed

9 tasks

jeliasson added 4 commits October 8, 2020 21:30

Module has no exported member

31f34c0

Exporting empty object for AzureAdUser

61509e5

Adding azureAd to decoders with noop

f35c2a0

Adding api jwt decoding and generator auth.js template

fe5cd60

dthyresson self-requested a review October 9, 2020 11:53

dthyresson self-assigned this Oct 9, 2020

dthyresson reviewed Oct 11, 2020

View reviewed changes

packages/api/src/auth/decoders/azureAd.ts Outdated Show resolved Hide resolved

dthyresson reviewed Oct 11, 2020

View reviewed changes

packages/api/src/auth/decoders/index.ts Outdated Show resolved Hide resolved

dthyresson reviewed Oct 11, 2020

View reviewed changes

packages/cli/src/commands/generate/auth/templates/azureAd.auth.js.template Outdated Show resolved Hide resolved

jeliasson marked this pull request as draft October 12, 2020 09:01

Renaming AzureAD references to AzureActiveDirectory

71aacd6

thedavidprice added the hacktoberfest-accepted label Oct 31, 2020

jeliasson and others added 4 commits November 7, 2020 11:54

Renaming decoder

581d0d2

Merge branch 'main' into feat/auth-azure-ad

914605f

Merge branch 'main' of git://github.com/redwoodjs/redwood into redwoo…

fe4578b

…djs-main

Merge branch 'main' into feat/auth-azure-ad

8085884

dthyresson added kind/improvement topic/auth labels Nov 8, 2020

jeliasson added 2 commits November 8, 2020 18:02

Renaming generator and updating template

ba10199

Adding token verification based off Auth0 sample

9b80e7e

jeliasson marked this pull request as ready for review November 8, 2020 20:28

jeliasson requested review from dthyresson and peterp November 8, 2020 22:24

Tobbe mentioned this pull request Nov 9, 2020

Publish PR packages to NPM #1458

Closed

jeliasson mentioned this pull request Nov 10, 2020

Support Azure AD authentication: Example redwoodjs/playground-auth#6

Merged

jeliasson added 2 commits November 10, 2020 19:50

Merge branch 'main' into feat/auth-azure-ad

6b2c389

Merge branch 'main' into feat/auth-azure-ad

71eb7b5

jeliasson mentioned this pull request Nov 13, 2020

GH Action to create packages from PRs #1459

Merged

Merge branch 'main' into feat/auth-azure-ad

390eb2e

Tobbe reviewed Dec 2, 2020

View reviewed changes

jeliasson and others added 12 commits December 3, 2020 16:51

Merge branch 'main' into feat/auth-azure-ad

f8645d2

Updating text if env is not set

a222300

Co-authored-by: Tobbe Lundberg <tobbe@tlundberg.com>

Fixing docs comment formatting

6d7044c

No need to export verifyAzureActiveDirectoryToken

0a9d8e9

One line

5b2caee

Co-authored-by: Tobbe Lundberg <tobbe@tlundberg.com>

One line

5c651a3

Co-authored-by: Tobbe Lundberg <tobbe@tlundberg.com>

Merge branch 'feat/auth-azure-ad' of https://github.com/jeliasson/red…

2b9910f

…wood into feat/auth-azure-ad

One line

a5c608a

Co-authored-by: Tobbe Lundberg <tobbe@tlundberg.com>

One line

f14a58c

Co-authored-by: Tobbe Lundberg <tobbe@tlundberg.com>

Removing restoreAuthState method

d458839

No method that corresponds with this in MSAL's UserAgentApplication class https://pub.dev/documentation/msal_js/latest/msal_js/UserAgentApplication-class.html#constructors

ESLint fix: There should be no empty line within import group

260a945

Updating auth's README with outdated SupportedAuthClients

086bd3e

Tobbe approved these changes Dec 3, 2020

View reviewed changes

Tobbe merged commit 2986015 into redwoodjs:main Dec 3, 2020

Tobbe added the next release docs label Dec 3, 2020

thedavidprice added this to the Next Release milestone Jan 6, 2021

jeliasson deleted the feat/auth-azure-ad branch January 8, 2021 19:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support Azure AD authentication: Implementation #1311

Support Azure AD authentication: Implementation #1311

jeliasson commented Oct 8, 2020 •

edited

Loading

peterp commented Oct 29, 2020

jeliasson commented Nov 8, 2020 •

edited

Loading

Tobbe commented Nov 9, 2020

jeliasson commented Nov 9, 2020 •

edited

Loading

Tobbe commented Nov 9, 2020 •

edited

Loading

github-actions bot commented Nov 25, 2020 •

edited

Loading

andrew-hwahin commented Nov 25, 2020

Tobbe left a comment

jeliasson commented Dec 3, 2020

AndrewLamYW commented Dec 4, 2020

Support Azure AD authentication: Implementation #1311

Support Azure AD authentication: Implementation #1311

Conversation

jeliasson commented Oct 8, 2020 • edited Loading

peterp commented Oct 29, 2020

jeliasson commented Nov 8, 2020 • edited Loading

Tobbe commented Nov 9, 2020

jeliasson commented Nov 9, 2020 • edited Loading

Tobbe commented Nov 9, 2020 • edited Loading

github-actions bot commented Nov 25, 2020 • edited Loading

andrew-hwahin commented Nov 25, 2020

Tobbe left a comment

Choose a reason for hiding this comment

jeliasson commented Dec 3, 2020

AndrewLamYW commented Dec 4, 2020

jeliasson commented Oct 8, 2020 •

edited

Loading

jeliasson commented Nov 8, 2020 •

edited

Loading

jeliasson commented Nov 9, 2020 •

edited

Loading

Tobbe commented Nov 9, 2020 •

edited

Loading

github-actions bot commented Nov 25, 2020 •

edited

Loading