Auth: Supabase 1.0 #1536
Auth: Supabase 1.0 #1536
Conversation
Tobbe
force-pushed
the
tobbe-supabase1_0
branch
from
3f76779
to
c550eeb
Compare
Tobbe
force-pushed
the
tobbe-supabase1_0
branch
from
c550eeb
to
58a757f
Compare
Tobbe
force-pushed
the
tobbe-supabase1_0
branch
from
58a757f
to
bb6f568
Compare
|
|
||
| export interface AuthClientSupabase extends AuthClient { | ||
| login(options: { | ||
| email: string | ||
| password: string | ||
| }): Promise<SupabaseAuthResponse> | ||
| }): Promise<{ | ||
| data: Session | null; |
There was a problem hiding this comment.
I am not a Typescript expert, but could one define a SupabaseAuthResponse and use it both here and in signup since url and provider are optional? Both share data, user, and error.
There was a problem hiding this comment.
Technically I could. But I don't want to. I think it would confuse people. Like "I wonder when this function would ever return url and provider?". What I'm doing here is exactly what supabase themselves are doing as well.
|
@Tobbe unless you want others to review, I think is good to merge. 🎉 Next steps are:
|
https://github.com/redwoodjs/redwoodjs.com/issues/478
@thedavidprice Consider yourself notified 🙂
Added a comment to existing issue redwoodjs/playground-auth#11
|
|
@kiwicopple If you find your way over here, these are the import lines I was talking about redwood/packages/auth/src/authClients/supabase.ts Lines 1 to 2 in 8a28c61 Is there a cleaner way to get at those types? |
|
Hey @Tobbe sorry for the delay - I saw this but it was right before we did our Beta launch and I've been swamped. They types are now exported, which from the auth library and from supabase-js Should make it a lot easier to import them now |
No description provided.