supabase@1.1.1 with cleaner imports #1564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dthyresson
approved these changes
Dec 13, 2020
|
I've seen that warning too. It's not related to this change, so I think we
should go ahead and merge this. We have a few eslint warnings that seem
easy enough to fix. If I can get the kids in bed at a reasonable time I'll
see if I can get a PR up for some of the warnings
…On Sun, Dec 13, 2020, 15:12 David Thyresson ***@***.***> wrote:
***@***.**** approved this pull request.
LGTM .
There is one warning about:
Replace `⏎········'`AZURE_ACTIVE_DIRECTORY_AUTHORITY`·env·var·is·not·set.'⏎······` with `'`AZURE_ACTIVE_DIRECTORY_AUTHORITY`·env·var·is·not·set.'`
Unsure how critical this is unless the warning will persist.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1564 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAHQSJHU6G6S4YZYVCVPW3SUTDWPANCNFSM4UVQ45PQ>
.
|
@dthyresson The warning is fixed here: #1582 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1536 (comment) for context