Fixed a few eslint warnings #1582
Merged
+32
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterp
reviewed
Dec 15, 2020
peterp
approved these changes
Dec 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've fixed 20 eslint warnings. (106 down to 86.)
I didn't look at all the
anywarnings.There are a couple of other warnings that I plain didn't know how to fix. Plz help? It's "Don't use
Functionas a type." inmockRequests.tsand "Don't use{}as a type" invscode.ts. Both can totally be left to be solved in another PR.As long as no one spots any error in what I've done I think this is good to merge, and then we can keep squashing those warnings in future PRs.