Add root-path to api-server

[jeliasson]

Seeks to implement root-path to @redwoodjs/api-server

Related issue

#1693 Add root-path to api-server

[github-actions]

📦 PR Packages

Click to Show Package Download Links

https://rw-pr-redwoodjs-com.s3.amazonaws.com/1691/create-redwood-app-0.28.3-257be2d.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1691/redwoodjs-api-0.28.3-257be2d.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1691/redwoodjs-api-server-0.28.3-257be2d.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1691/redwoodjs-auth-0.28.3-257be2d.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1691/redwoodjs-cli-0.28.3-257be2d.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1691/redwoodjs-core-0.28.3-257be2d.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1691/redwoodjs-dev-server-0.28.3-257be2d.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1691/redwoodjs-eslint-config-0.28.3-257be2d.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1691/redwoodjs-eslint-plugin-redwood-0.28.3-257be2d.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1691/redwoodjs-forms-0.28.3-257be2d.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1691/redwoodjs-internal-0.28.3-257be2d.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1691/redwoodjs-prerender-0.28.3-257be2d.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1691/redwoodjs-router-0.28.3-257be2d.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1691/redwoodjs-structure-0.28.3-257be2d.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1691/redwoodjs-testing-0.28.3-257be2d.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1691/redwoodjs-web-0.28.3-257be2d.tgz

Install this PR by running yarn rw upgrade --pr 1691:0.28.3-257be2d

[peterp]

Hey @jeliasson, is this ready for review?

[jeliasson]

@peterp Sure, thanks!

[peterp]

Thanks for this! Such a nice and quick PR to review!

[peterp]

This is very very ready to go, I think just passing the rootPath value to http and then we can ship it!

[jeliasson]

@peterp So two things;

1. Changing back to less-pretty way of handling root path construction

While @Tobbe's suggestion was much more elegant, it did not handle / or nullish. It would result in //. Because of this I reverted to the previous implementation. Do you have something that would make this fly, while being pretty?

2. Using rootPath as option with root-path as alias

Is there a neat way of passing rootPath where the yargs option would be root-path? Currently I'm having rootPath as option, and root-path as alias.

From what I can tell (and tested), this is a working implementation and I'll be happy to make this prettier for 0.29.0 if you want to get this out the door in 0.28.0.. However, if you feel that is not ready - don't hesitate to skip this PR for next sprint.

Also, sorry for my mountain of commits. I should really learn the git rebase stuff. 😅

/cc @thedavidprice @Tobbe

[thedavidprice]

Release Timing Check-in: we need to bump this to the next release cycle. Please continue with the review. But hold off on merge until post v0.28 release.

[thedavidprice]

@jeliasson For documentation, can you provide an example about how to use this? I'm assuming it's something along the lines of #1693

[jeliasson]

For documentation, can you provide an example about how to use this? I'm assuming it's something along the lines of #1693

@thedavidprice Yes. It's implemented as #1693 describes. I can document it on the website, but I'm not entirely sure where this would go. Can you point me in the right direction? 🙏

[thedavidprice]

@jeliasson roger that!

Actually, this is important to work Danny is doing here: #2217

Could you take a look at that PR and make sure the option is correctly included. Then we'll document it all in the CLI Docs. Thanks!

[jeliasson]

@thedavidprice Defo. I'll give @dac09 a chat and we get that in there.