New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix router typescript problem #1737

Merged

dac09 merged 1 commit into redwoodjs:main from dac09:fix/router-ts

Feb 5, 2021

+0 −1

Collaborator

dac09 commented Feb 5, 2021

Small fix, big rewards ;)


          Fix router typescript problem

8df44ba

Tobbe approved these changes

View reviewed changes

github-actions bot commented Feb 5, 2021

📦 PR Packages

Click to Show Package Download Links

https://rw-pr-redwoodjs-com.s3.amazonaws.com/1737/create-redwood-app-0.24.0-8df44ba.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1737/redwoodjs-api-0.24.0-8df44ba.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1737/redwoodjs-api-server-0.24.0-8df44ba.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1737/redwoodjs-auth-0.24.0-8df44ba.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1737/redwoodjs-cli-0.24.0-8df44ba.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1737/redwoodjs-core-0.24.0-8df44ba.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1737/redwoodjs-dev-server-0.24.0-8df44ba.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1737/redwoodjs-eslint-config-0.24.0-8df44ba.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1737/redwoodjs-eslint-plugin-redwood-0.24.0-8df44ba.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1737/redwoodjs-forms-0.24.0-8df44ba.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1737/redwoodjs-internal-0.24.0-8df44ba.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1737/redwoodjs-router-0.24.0-8df44ba.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1737/redwoodjs-structure-0.24.0-8df44ba.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1737/redwoodjs-testing-0.24.0-8df44ba.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1737/redwoodjs-web-0.24.0-8df44ba.tgz

Install this PR by running yarn rw upgrade --pr 1737:0.24.0-8df44ba

dac09 added this to the v0.25.0 milestone

dac09 merged commit 3774053 into redwoodjs:main

dac09 deleted the fix/router-ts branch

February 5, 2021 13:00

peterp reviewed

View reviewed changes

Contributor

peterp left a comment

We should probably remove src/index.d.ts from "files"

I understand now that TS looks for the typing associated against main, but I would prefer if we were explicit about it.

Collaborator Author

dac09 commented Feb 5, 2021

@peterp here's the explicit version :) #1741

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment