Docs: Update contributor workflow to yarn rwt link #1803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for creating this @jtoar, but I think we should avoid changing the official docs for a little while, maybe have it in a "New contributor flow (beta)" section instead in a collaposible or something? |
|
@dac09 I can just keep this PR unmerged till you think the command's good to advertise? Was just writing this up to keep tempo. We can always show it off to our "insiders" via the forums or discord! Just to make sure, you do see |
dac09
changed the title
dac09
reviewed
Feb 22, 2021
|
@jtoar Never mind my comment before, LGTM! Left a small suggestion :) |
dac09
approved these changes
Feb 22, 2021
Tobbe
reviewed
Feb 22, 2021
Tobbe
reviewed
Feb 22, 2021
Tobbe
reviewed
Feb 22, 2021
Tobbe
reviewed
Feb 22, 2021
Co-authored-by: Daniel Choudhury <dannychoudhury@gmail.com>
Co-authored-by: Tobbe Lundberg <tobbe@tlundberg.com>
Co-authored-by: Tobbe Lundberg <tobbe@tlundberg.com>
Co-authored-by: Tobbe Lundberg <tobbe@tlundberg.com>
…dwood into ds-update-contributing-docs
Tobbe
reviewed
Feb 22, 2021
Co-authored-by: Tobbe Lundberg <tobbe@tlundberg.com>
Tobbe
reviewed
Feb 22, 2021
Tobbe
reviewed
Feb 22, 2021
Tobbe
reviewed
Feb 22, 2021
Co-authored-by: Tobbe Lundberg <tobbe@tlundberg.com>
Co-authored-by: Tobbe Lundberg <tobbe@tlundberg.com>
Tobbe
reviewed
Feb 22, 2021
Co-authored-by: Tobbe Lundberg <tobbe@tlundberg.com>
dac09
added a commit
to dac09/redwood
that referenced
this pull request
Feb 24, 2021
… fix/dm-babel-register * 'fix/dm-babel-register' of github.com:dac09/redwood: Remove bundlesize dependency (redwoodjs#1844) upgrade execa; fix test.js cwd (redwoodjs#1846) Make ESLint configuration aware of "env." (redwoodjs#1827) Use createMany in Seed database example (redwoodjs#1776) Docs: Update contributor workflow to yarn rwt link (redwoodjs#1803) fix(page-loader): Adds types for pageLoadingContext | Fix for pageLoader during prerender (redwoodjs#1832) Minify CSS in production builds (redwoodjs#1697) New contributor workflow (redwoodjs#1792) Improve/template and auth setup tests (redwoodjs#1834)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR documents the new contributor workflow, made possible by #1792, which adds the
yarn rwt linkcommand.