Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix rw test command when run from dir other than root and upgrade execa #1846

Merged
merged 2 commits into from
Feb 24, 2021

Conversation

thedavidprice
Copy link
Contributor

This PR fixes an edge case where the Test command would fail due to not having a cwd set when Execa runs rw prisma ... commands. It also upgrades to execa 5.0, which is the version used by Prisma.

E2E = ✅

@thedavidprice thedavidprice added this to the next release milestone Feb 24, 2021
@github-actions
Copy link

📦 PR Packages

Click to Show Package Download Links

https://rw-pr-redwoodjs-com.s3.amazonaws.com/1846/create-redwood-app-0.25.1-bfa1f7a.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1846/redwoodjs-api-0.25.1-bfa1f7a.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1846/redwoodjs-api-server-0.25.1-bfa1f7a.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1846/redwoodjs-auth-0.25.1-bfa1f7a.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1846/redwoodjs-cli-0.25.1-bfa1f7a.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1846/redwoodjs-core-0.25.1-bfa1f7a.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1846/redwoodjs-dev-server-0.25.1-bfa1f7a.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1846/redwoodjs-eslint-config-0.25.1-bfa1f7a.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1846/redwoodjs-eslint-plugin-redwood-0.25.1-bfa1f7a.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1846/redwoodjs-forms-0.25.1-bfa1f7a.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1846/redwoodjs-internal-0.25.1-bfa1f7a.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1846/redwoodjs-prerender-0.25.1-bfa1f7a.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1846/redwoodjs-router-0.25.1-bfa1f7a.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1846/redwoodjs-structure-0.25.1-bfa1f7a.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1846/redwoodjs-testing-0.25.1-bfa1f7a.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1846/redwoodjs-web-0.25.1-bfa1f7a.tgz

Install this PR by running yarn rw upgrade --pr 1846:0.25.1-bfa1f7a

@thedavidprice thedavidprice merged commit 5717e2e into main Feb 24, 2021
@thedavidprice thedavidprice deleted the dsp-fix-execa branch February 24, 2021 01:57
dac09 added a commit to dac09/redwood that referenced this pull request Feb 24, 2021
… fix/dm-babel-register

* 'fix/dm-babel-register' of github.com:dac09/redwood:
  Remove bundlesize dependency (redwoodjs#1844)
  upgrade execa; fix test.js cwd (redwoodjs#1846)
  Make ESLint configuration aware of "env." (redwoodjs#1827)
  Use createMany in Seed database example (redwoodjs#1776)
  Docs: Update contributor workflow to yarn rwt link (redwoodjs#1803)
  fix(page-loader): Adds types for pageLoadingContext | Fix for pageLoader during prerender (redwoodjs#1832)
  Minify CSS in production builds (redwoodjs#1697)
  New contributor workflow (redwoodjs#1792)
  Improve/template and auth setup tests (redwoodjs#1834)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant