Add curly rule for blocks

[Krisztiaan]

ESlint rule against one-liners, see thread below.

As for the braces for blocks, this should probably be enforced via eslint, because my (and potentially others') config defaults to one-liners.

💯 I was actually surprised it wasn't already a rule

Originally posted by @Tobbe in #1824 (comment)

[github-actions]

📦 PR Packages

Click to Show Package Download Links

https://rw-pr-redwoodjs-com.s3.amazonaws.com/1836/create-redwood-app-0.25.1-0c92497.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1836/redwoodjs-api-0.25.1-0c92497.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1836/redwoodjs-api-server-0.25.1-0c92497.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1836/redwoodjs-auth-0.25.1-0c92497.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1836/redwoodjs-cli-0.25.1-0c92497.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1836/redwoodjs-core-0.25.1-0c92497.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1836/redwoodjs-dev-server-0.25.1-0c92497.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1836/redwoodjs-eslint-config-0.25.1-0c92497.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1836/redwoodjs-eslint-plugin-redwood-0.25.1-0c92497.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1836/redwoodjs-forms-0.25.1-0c92497.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1836/redwoodjs-internal-0.25.1-0c92497.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1836/redwoodjs-prerender-0.25.1-0c92497.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1836/redwoodjs-router-0.25.1-0c92497.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1836/redwoodjs-structure-0.25.1-0c92497.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1836/redwoodjs-testing-0.25.1-0c92497.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1836/redwoodjs-web-0.25.1-0c92497.tgz

Install this PR by running yarn rw upgrade --pr 1836:0.25.1-0c92497

[Tobbe]

Oops. That was a bigger change than I anticipated. Mostly in the structure package.

@peterp What do you think?

[thedavidprice]

Thanks, @Krisztiaan!

Looked through about half and agree this improves readability. I defer to PP for final say.

[Tobbe]

Looked through about half and agree this improves readability.

It also makes it a lot easier and safer to add more code to a branch of the if/else-statement.

[peterp]

Love it 👍

[thedavidprice]

Hi @Krisztiaan I'd like to get this into the next release. There's a merge conflict from Peter's PR here #1827

Didn't want to assume I could just move your change to .eslintrc over to the new .eslintrc.js. Guessing there might be some other updates as well. Sorry for the double work. Appreciate the help!

[Krisztiaan]

@thedavidprice Yeah you could. Rebased, should be g2g now.