Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Update CONTRIBUTING.md rwt link docs #1852

Merged
merged 2 commits into from
Feb 24, 2021
Merged

Conversation

dac09
Copy link
Collaborator

@dac09 dac09 commented Feb 24, 2021

Removes step for upgrading to canary (which can cause probablems with rwt link)

Removes step for upgrading to canary (which can cause probablems with rwt link)
@dac09 dac09 requested a review from jtoar February 24, 2021 20:14
@dac09 dac09 changed the title Update CONTRIBUTING.md Update CONTRIBUTING.md rwt link docs Feb 24, 2021
@dac09 dac09 changed the title Update CONTRIBUTING.md rwt link docs Docs: Update CONTRIBUTING.md rwt link docs Feb 24, 2021
@github-actions
Copy link

📦 PR Packages

Click to Show Package Download Links

https://rw-pr-redwoodjs-com.s3.amazonaws.com/1852/create-redwood-app-0.25.1-f45bb43.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1852/redwoodjs-api-0.25.1-f45bb43.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1852/redwoodjs-api-server-0.25.1-f45bb43.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1852/redwoodjs-auth-0.25.1-f45bb43.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1852/redwoodjs-cli-0.25.1-f45bb43.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1852/redwoodjs-core-0.25.1-f45bb43.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1852/redwoodjs-dev-server-0.25.1-f45bb43.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1852/redwoodjs-eslint-config-0.25.1-f45bb43.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1852/redwoodjs-eslint-plugin-redwood-0.25.1-f45bb43.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1852/redwoodjs-forms-0.25.1-f45bb43.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1852/redwoodjs-internal-0.25.1-f45bb43.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1852/redwoodjs-prerender-0.25.1-f45bb43.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1852/redwoodjs-router-0.25.1-f45bb43.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1852/redwoodjs-structure-0.25.1-f45bb43.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1852/redwoodjs-testing-0.25.1-f45bb43.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1852/redwoodjs-web-0.25.1-f45bb43.tgz

Install this PR by running yarn rw upgrade --pr 1852:0.25.1-f45bb43

Copy link
Contributor

@jtoar jtoar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dac09 dac09 merged commit dc726e8 into main Feb 24, 2021
@dac09 dac09 deleted the update-rwt-contrib-docs branch February 24, 2021 20:57
dac09 added a commit to dac09/redwood that referenced this pull request Feb 24, 2021
… feature/hide-entry-js

* 'feature/hide-entry-js' of github.com:dac09/redwood:
  Docs: Update CONTRIBUTING.md `rwt link` docs (redwoodjs#1852)
  Fixes generating scenarios for relations where the field name is different than the relation name (redwoodjs#1848)
@thedavidprice
Copy link
Contributor

Wait... should we then warn people to not use canary (or use some specific version range)? 'Cause my workflow for QA almost always has me working off canary in my project.

@thedavidprice thedavidprice added this to the next release milestone Feb 25, 2021
@jtoar
Copy link
Contributor

jtoar commented Feb 26, 2021

@thedavidprice I'll do this in another PR; definitely worth making sure the steps are exact.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants