Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes generating scenarios for relations where the field name is different than the relation name #1848

Merged
merged 5 commits into from
Feb 24, 2021

Conversation

cannikin
Copy link
Member

@cannikin cannikin commented Feb 24, 2021

Closes #1649

@github-actions
Copy link

github-actions bot commented Feb 24, 2021

📦 PR Packages

Click to Show Package Download Links

https://rw-pr-redwoodjs-com.s3.amazonaws.com/1848/create-redwood-app-0.25.1-68c4f97.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1848/redwoodjs-api-0.25.1-68c4f97.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1848/redwoodjs-api-server-0.25.1-68c4f97.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1848/redwoodjs-auth-0.25.1-68c4f97.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1848/redwoodjs-cli-0.25.1-68c4f97.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1848/redwoodjs-core-0.25.1-68c4f97.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1848/redwoodjs-dev-server-0.25.1-68c4f97.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1848/redwoodjs-eslint-config-0.25.1-68c4f97.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1848/redwoodjs-eslint-plugin-redwood-0.25.1-68c4f97.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1848/redwoodjs-forms-0.25.1-68c4f97.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1848/redwoodjs-internal-0.25.1-68c4f97.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1848/redwoodjs-prerender-0.25.1-68c4f97.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1848/redwoodjs-router-0.25.1-68c4f97.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1848/redwoodjs-structure-0.25.1-68c4f97.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1848/redwoodjs-testing-0.25.1-68c4f97.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1848/redwoodjs-web-0.25.1-68c4f97.tgz

Install this PR by running yarn rw upgrade --pr 1848:0.25.1-68c4f97

@cannikin cannikin marked this pull request as ready for review February 24, 2021 19:01
@cannikin
Copy link
Member Author

@thedavidprice assuming the checks pass, this should be good!

@brentjanderson did you want to try this out? You can install this PR version of Redwood with yarn rw upgrade --pr 1848:0.25.1-fbf4a83

@brentjanderson
Copy link
Contributor

Worked for me on that test repo. :shipit:

@thedavidprice
Copy link
Contributor

🚀

@thedavidprice thedavidprice merged commit bcdf1e2 into main Feb 24, 2021
@thedavidprice thedavidprice deleted the rc-service-relations branch February 24, 2021 19:17
@thedavidprice thedavidprice added this to the next release milestone Feb 24, 2021
dac09 added a commit to dac09/redwood that referenced this pull request Feb 24, 2021
… feature/hide-entry-js

* 'feature/hide-entry-js' of github.com:dac09/redwood:
  Docs: Update CONTRIBUTING.md `rwt link` docs (redwoodjs#1852)
  Fixes generating scenarios for relations where the field name is different than the relation name (redwoodjs#1848)
@jvanbaarsen
Copy link
Contributor

🎉 Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Service / SDL generation is broken when using relations
4 participants