-
Notifications
You must be signed in to change notification settings - Fork 979
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLI Storybook command: add output directory option #2168
Conversation
.option('build-directory', { | ||
describe: 'Directory in web/ to store static files', | ||
type: 'string', | ||
default: 'storybook-static', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@peterp this is the current default behavior. My inclination is to set this as something like public/storybook
, taking advantage of the Public dir to serve static files. Thoughts either way?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, I like that, we just have to remember that this would be a breaking change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed to public/storybook here #2176
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
dependency of #2073
yarn redwood storybook --build
This adds the
--output-directory
option toyarn build-storybook
, providing an override to the default directory to store the built static files.TBD whether or not the default directory should be
web/public/storybook
. Files in public will be statically served during both local dev or deployment.Part two PR here #2176