Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ESLint warnings #262

Merged
merged 11 commits into from
Mar 15, 2020
Merged

Fix ESLint warnings #262

merged 11 commits into from
Mar 15, 2020

Conversation

peterp
Copy link
Contributor

@peterp peterp commented Mar 15, 2020

Our babel config ignored test files. The warnings where caused by trying to lint the test files. I no longer ignore test files, and I don't build them when NODE_ENV is production.

I tried eslint-import-resolver-webpack so that the directory named modules were resolved, but it didn't seem to do anything.

Closes #258

@peterp peterp changed the title Fix warnings in linter Fix ESLint warnings Mar 15, 2020
@peterp peterp merged commit 12fd80c into master Mar 15, 2020
mohsen1 pushed a commit to mohsen1/redwood that referenced this pull request Apr 12, 2020
@thedavidprice thedavidprice deleted the pp-fix-warnings-in-linter branch June 9, 2020 23:05
@thedavidprice thedavidprice added this to the unassigned-version milestone May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Outstanding ESlint Warning: Babel Error reported by eslint-import-resolver-babel-module
2 participants