Make the test project generator more composable #3099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dac09
force-pushed
the
improve/project-generator
branch
from
be68e6f
to
d98aaa6
Compare
…ect-generator * 'main' of github.com:redwoodjs/redwood: Ignore graphql-server TS errors (redwoodjs#3126) Prerender `Private` routes (redwoodjs#3124) Remove verdaccio configurationa and docs. (redwoodjs#3120) Remove old esbuild/ babel build commands from core. (redwoodjs#3119) Remove undeleted history file. Add pretranspile + programatic build to API side. (redwoodjs#2938) fix scaffoding typo (redwoodjs#3112) Fixes a couple of typos, return `true` if no roles were provided to requireAuth() (redwoodjs#3107) fix(webpack-manifest): Manifest plugin errors out if manifest.json exists (redwoodjs#3104) Upgrades envelop to 1.0.0 (redwoodjs#3106) Add Clerk as an auth provider (redwoodjs#3080) just plain read the file (redwoodjs#3108) Upgrade setup tailwind (redwoodjs#3087) Firebase auth options (redwoodjs#2824) fix(rwfw): Fixes rufus building graphql-server package (redwoodjs#3100) upgrade to Jest v27 (redwoodjs#2893)
…into improve/project-generator * 'improve/project-generator' of github.com:dac09/redwood:
dac09
commented
Jul 26, 2021
packages/cli/src/commands/dev.js
Outdated
| @@ -93,8 +93,7 @@ export const handler = async ({ | |||
| const jobs = { | |||
| api: { | |||
| name: 'api', | |||
| command: | |||
| `yarn cross-env NODE_ENV=development NODE_OPTIONS=--enable-source-maps yarn nodemon --watch "${redwoodConfigPath}" --exec "yarn rw-api-server-watch"`, | |||
| command: `yarn cross-env NODE_ENV=development NODE_OPTIONS=--enable-source-maps yarn nodemon --watch "${redwoodConfigPath}" --exec "yarn rw-api-server-watch"`, | |||
…ect-generator * 'main' of github.com:redwoodjs/redwood: [setup tailwind] Add ability to skip install (redwoodjs#3136) upgrade prisma v2.28 (redwoodjs#3139) fix(generate-page): map param types to TS (redwoodjs#3138) fix storybook build, restore E2E specs, try CircleCI (redwoodjs#3132) GraphQL useMutation options (redwoodjs#3041) Typing services on makeMergedSchema (redwoodjs#3129) Resolves Typescript errors in useRedwoodLogger plugin in GraphQL-server (redwoodjs#3127)
|
@thedavidprice done with changes. Plz murj if happy. ✅ Tailwind works |
|
No time to review now. Merging and will go through later. Follow up PR if changes suggested. Thanks! |
| @@ -19,7 +19,7 @@ export const builder = (yargs) => { | |||
| description: 'Which dev server(s) to start', | |||
| type: 'array', | |||
| }) | |||
| .positional('forward', { | |||
| .option('forward', { | |||
There was a problem hiding this comment.
before I merge, can we think of any good reason why this would have been a positional originally?
There was a problem hiding this comment.
Just a typo/bug - we probably never noticed it because it runs headless in the workflow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds ability to
--linkbut can rename to--rwfwAlso