Remove auto import of db
#334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great! Let's make sure to document this change well in the release docs, it's a big breaking change. |
|
@mojombo good timing! Peter and I are talking about this just now and he’s made it very clear in Release notes. Want to make sure Breaking Change highlighted in the Twitter announcement as well — can you take care of that part? And I’ll handle communication in the forum. Sound good? |
|
Yes, it's a deal! |
thedavidprice
approved these changes
Mar 25, 2020
mohsen1
pushed a commit
to mohsen1/redwood
that referenced
this pull request
Apr 12, 2020
Remove auto import of `db`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes some of the magic.
We feel that having the import visible in the services will help people understand that services are a layer where you can connect your schema to a database, but can also be a request to an API, to Redis, or anything else... the possibilities are endless.