Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs inaccurate statement #812

Closed
NickBolles opened this issue Jul 9, 2020 · 7 comments · Fixed by redwoodjs/redwoodjs-com-archive#361
Closed

Docs inaccurate statement #812

NickBolles opened this issue Jul 9, 2020 · 7 comments · Fixed by redwoodjs/redwoodjs-com-archive#361

Comments

@NickBolles
Copy link

I'm not sure this statement on the homepage is true:

we didn't even omit any import statements or cheat to get the code smaller, honest!

Pretty sure an import for db is missing. If your going to explicitly claim that might as well add it :)

@jtoar
Copy link
Contributor

jtoar commented Jul 9, 2020

@NickBolles Before #334 we used to auto import db too! But very true, those days are behind us. Maybe we could add import db ... to the top and then say "we didn't omit any other import statements..."

@NickBolles
Copy link
Author

@NickBolles Before #334 we used to auto import db too! But very true, those days are behind us. Maybe we could add import db ... to the top and then say "we didn't omit any other import statements..."

Gotcha! Makes sense.

@ryanmdoyle
Copy link
Contributor

@NickBolles Before #334 we used to auto import db too! But very true, those days are behind us. Maybe we could add import db ... to the top and then say "we didn't omit any other import statements..."

Just started poking around with redwood and saw this is a few months old. I think I could handle this. It should be in the redwoodjs.com repo so I can handle it there. Should I create a new issue in that repo or just go for it?

@forresthayes
Copy link
Contributor

Hey @ryanmdoyle

I think you should go for it! You're correct that the change should be to the redwoodjs.com repo. I've been making some minor docs changes recently, so feel free to reach out if you have any questions.

@thedavidprice
Copy link
Contributor

@ryanmdoyle just wanted to give another 👍 that you should just go for it. Here's the code that needs updating (no screenshot required; just markdown!):
https://github.com/redwoodjs/redwoodjs.com/blob/main/code/html/index.html

Please link to this issue when you do creat the PR so we can close it out.

And thanks in advance!

@ryanmdoyle
Copy link
Contributor

@thedavidprice Thanks! Working on it now.

@ryanmdoyle
Copy link
Contributor

Should be good now. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants