Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix type definitions for page components that take props #4219

Merged
merged 2 commits into from
Jan 22, 2022
Merged

Fix type definitions for page components that take props #4219

merged 2 commits into from
Jan 22, 2022

Commits on Jan 20, 2022

  1. Fix type definitions for pages that take props 

    Sometimes it's convenient for a Redwood page to take props. I use this to pass in optional props so I can mock specific states in Storybook (see https://github.com//zorro-project/zorro/blob/7fc3c1abec3e5296e8cc2e1a5164a177b9d7a16d/redwood/web/src/pages/SignUp/VideoPage/VideoPage.tsx#L15).

Right now, if a Redwood page takes props it fails the `<Route>` typechecks. This PR loosens up the typecheck so it passes.
    @corbt
    corbt committed Jan 20, 2022
    Configuration menu
    Copy the full SHA
    3fb12b2 View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2022

  1. Merge branch 'main' into typedefs

    @thedavidprice
    thedavidprice committed Jan 22, 2022
    Configuration menu
    Copy the full SHA
    1c7ab73 View commit details
    Browse the repository at this point in the history