Fix type definitions for page components that take props #4219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes it's convenient for a Redwood page to take props. I use this to pass in optional props so I can mock specific states in Storybook (see https://github.com//zorro-project/zorro/blob/7fc3c1abec3e5296e8cc2e1a5164a177b9d7a16d/redwood/web/src/pages/SignUp/VideoPage/VideoPage.tsx#L15). Right now, if a Redwood page takes props it fails the `<Route>` typechecks. This PR loosens up the typecheck so it passes.
|
Thanks @corbt! |
dac09
added a commit
that referenced
this pull request
Jan 25, 2022
…s-setup * 'main' of github.com:redwoodjs/redwood: (87 commits) Update scripts tsconfig (#4258) Update dependency @types/aws-lambda to v8.10.92 (#4260) Update dependency @apollo/client to v3.5.8 (#4262) Update dependency msw to v0.36.7 (#4252) Update typescript-eslint monorepo to v5.10.1 (#4256) Update dependency webpack-cli to v4.9.2 (#4254) Update dependency @supabase/supabase-js to v1.29.4 (#4253) Update dependency supertokens-auth-react to v0.18.4 (#4255) Update dependency ts-morph to v13.0.3 (#4251) Update dependency supertokens-auth-react to v0.18.3 (#4248) Update dependency esbuild to v0.14.13 (#4249) Fixed netlify api config (#4247) Add storybook ci option to test that Storybook starts "ok" (#3515) Update dependency react-hook-form to v7.25.0 (#4245) Update dependency firebase-admin to v10.0.2 (#4244) Fix type definitions for pages that take props (#4219) update yarn.lock v0.42.1 update yarn.lock Pin dependency @types/yargs to v16.0.4 (#4243) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes it's convenient for a Redwood page to take props. I use this to pass in optional props so I can mock specific states in Storybook (see https://github.com//zorro-project/zorro/blob/7fc3c1abec3e5296e8cc2e1a5164a177b9d7a16d/redwood/web/src/pages/SignUp/VideoPage/VideoPage.tsx#L15).
Right now, if a Redwood page takes props it fails the
<Route>typechecks. This PR loosens up the typecheck so it passes.