-
Notifications
You must be signed in to change notification settings - Fork 977
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(windicss): add windicss ui setup #5194
Conversation
✅ Deploy Preview for redwoodjs-docs canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Olyno I've used windicss once and it was a great experience. I tested this out locally and left a few comments. You can also lint fix to get some of the GitHub warnings to go away.
Due to a conflict with local packages from the Framework project, I wasn't able to test what I've done so far
Mind expanding on this? I was able to get things hooked locally up using yarn rwfw
. And as long as you run the command with --no-isntall
, node_modules
won't be reset (and then you can install after the setup command). Did you have a hard time with the contributing docs? You can also try Gitpod, it's often just an easier experience.
When I tried it locally, I encountered some problems. For example, when running the command "yarn rwfw", I got an error that it was not possible to find the workspace "web": I also got an error at one point with the dependencies: I honestly don't know how to explain these issues. I didn't try Gitpod, but it can be a good option if it works better. I would have highlighted it in the documentation in these cases. There's a thread on the Discord with probably more information if you're curious to find out what's wrong). Also, I think that the "Test the CLI" part should be before the "Test the Framework" part because it seems that we don't need sync, which would allow us to go straight to the concrete. |
@jtoar re: local dev topic — we have two next steps to address now that we're beyond 1.0:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Olyno here's another round of reviews. I think it's good to go after all these are addressed.
Co-authored-by: Dominic Saadi <32992335+jtoar@users.noreply.github.com>
Co-authored-by: Dominic Saadi <32992335+jtoar@users.noreply.github.com>
Co-authored-by: Dominic Saadi <32992335+jtoar@users.noreply.github.com>
Co-authored-by: Dominic Saadi <32992335+jtoar@users.noreply.github.com>
Co-authored-by: Dominic Saadi <32992335+jtoar@users.noreply.github.com>
Co-authored-by: Dominic Saadi <32992335+jtoar@users.noreply.github.com>
…redwood into feature/setup-ui-windicss
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Olyno, this looks great. Let's get this one merged
Description
Hi 👋🏻
Here is a pull request to implement the WindiCSS UI library. It is a great alternative to Tailwind, with fewer configurations, and more utilities.
Currently, this pull request should be tested. Due to a conflict with local packages from the Framework project, I wasn't able to test what I've done so far.