Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Replacing Prisma.xxx types with types from 'types/graphql' #5740

Merged
merged 3 commits into from Jun 21, 2022
Merged

docs: Replacing Prisma.xxx types with types from 'types/graphql' #5740

merged 3 commits into from Jun 21, 2022

Conversation

rushabhhere
Copy link
Contributor

@rushabhhere rushabhhere commented Jun 11, 2022

Changed the TS code for the posts service to use QueryResolvers and MutationResolvers types from 'types/graphql'? The current documentation uses Prisma.xxx types like so:

image

But as I was following along with the tutorial, I found that the code generated by redwood for the posts service was using the types from 'types/graphql' like so:

image

(Made this change in side-quest.md and saving-data.md)

@netlify
Copy link

netlify bot commented Jun 11, 2022

Deploy Preview for redwoodjs-docs ready!

Name Link
🔨 Latest commit 1030c8a
🔍 Latest deploy log https://app.netlify.com/sites/redwoodjs-docs/deploys/62b1a4ecb37fb300095b1265
😎 Deploy Preview https://deploy-preview-5740--redwoodjs-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@mrguiman
Copy link
Contributor

Same thing on the contacts service's code block, might be interesting to take care of that at the same time ?

@rushabhhere
Copy link
Contributor Author

@mrguiman hey, I have changed the contacts service as well, if you check the diff. Is there another occurrence of wrong types that I missed?

@mrguiman
Copy link
Contributor

mrguiman commented Jun 11, 2022

@rushabhhere Nope that's my bad, I checked the changes but somehow must have dosed off, thanks a lot

@dthyresson dthyresson requested a review from cannikin June 14, 2022 22:47
@dthyresson dthyresson added the release:docs This PR only updates docs label Jun 14, 2022
Copy link
Contributor

@jtoar jtoar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch @rushabhhere, looks good!

@cannikin
Copy link
Member

Might want to ping @Tobbe as he added these Typescript blocks!

@cannikin cannikin requested review from Tobbe and removed request for cannikin June 15, 2022 16:25
@jtoar
Copy link
Contributor

jtoar commented Jun 21, 2022

@rushabhhere I was trying to get this one merged and normally I can update branches if they're out-of-date with the main to do so, but for some reason I can't update this one. Any chance you could rebase onto main?

@rushabhhere
Copy link
Contributor Author

@jtoar I have updated the branch with all the commits it was behind. Could you check if this is what you wanted?

@jtoar
Copy link
Contributor

jtoar commented Jun 21, 2022

@rushabhhere yeah this is great, can merge now.

@jtoar jtoar merged commit f127efc into redwoodjs:main Jun 21, 2022
@redwoodjs-bot redwoodjs-bot bot added this to the next-release milestone Jun 21, 2022
dac09 added a commit to dac09/redwood that referenced this pull request Jun 23, 2022
…ctmode-gen

* 'main' of github.com:redwoodjs/redwood:
  validateUniquess optional prismaClient parameter (redwoodjs#5763)
  fix(deps): update dependency prettier to v2.7.1 (redwoodjs#5808)
  fix(deps): update dependency eslint to v8.18.0 (redwoodjs#5806)
  fix(deps): update dependency systeminformation to v5.11.21 (redwoodjs#5805)
  fix(deps): update dependency @apollo/client to v3.6.9 (redwoodjs#5804)
  chore(deps): update dependency firebase to v9.8.3 (redwoodjs#5799)
  Add Azure AD B2C auth provider compatibility (redwoodjs#5781)
  chore(deps): update dependency esbuild to v0.14.47 (redwoodjs#5798)
  Maps JSON GraphQL Scalars to Prisma Json field types for compatibility (redwoodjs#5796)
  fix(deps): update prisma monorepo to v3.15.2 (redwoodjs#5789)
  fix(deps): update dependency core-js to v3.23.2 (redwoodjs#5790)
  fix(deps): update dependency webpack to v5.73.0 (redwoodjs#5755)
  docs: update disable api layer/database to include disabling prisma (redwoodjs#5528)
  Fix typo in testing docs (redwoodjs#5782)
  fix typo (redwoodjs#5777)
  docs: Replacing Prisma.xxx types with types from 'types/graphql' (redwoodjs#5740)
  Reorganize auth docs into sub-categories (redwoodjs#5787)
@jtoar jtoar modified the milestones: next-release, v2.1.0 Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:docs This PR only updates docs
Projects
Status: Archived
Development

Successfully merging this pull request may close these issues.

None yet

5 participants