New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Replacing Prisma.xxx types with types from 'types/graphql' #5740
Conversation
✅ Deploy Preview for redwoodjs-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Same thing on the contacts service's code block, might be interesting to take care of that at the same time ? |
@mrguiman hey, I have changed the contacts service as well, if you check the diff. Is there another occurrence of wrong types that I missed? |
@rushabhhere Nope that's my bad, I checked the changes but somehow must have dosed off, thanks a lot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great catch @rushabhhere, looks good!
Might want to ping @Tobbe as he added these Typescript blocks! |
@rushabhhere I was trying to get this one merged and normally I can update branches if they're out-of-date with the main to do so, but for some reason I can't update this one. Any chance you could rebase onto main? |
@jtoar I have updated the branch with all the commits it was behind. Could you check if this is what you wanted? |
@rushabhhere yeah this is great, can merge now. |
…ctmode-gen * 'main' of github.com:redwoodjs/redwood: validateUniquess optional prismaClient parameter (redwoodjs#5763) fix(deps): update dependency prettier to v2.7.1 (redwoodjs#5808) fix(deps): update dependency eslint to v8.18.0 (redwoodjs#5806) fix(deps): update dependency systeminformation to v5.11.21 (redwoodjs#5805) fix(deps): update dependency @apollo/client to v3.6.9 (redwoodjs#5804) chore(deps): update dependency firebase to v9.8.3 (redwoodjs#5799) Add Azure AD B2C auth provider compatibility (redwoodjs#5781) chore(deps): update dependency esbuild to v0.14.47 (redwoodjs#5798) Maps JSON GraphQL Scalars to Prisma Json field types for compatibility (redwoodjs#5796) fix(deps): update prisma monorepo to v3.15.2 (redwoodjs#5789) fix(deps): update dependency core-js to v3.23.2 (redwoodjs#5790) fix(deps): update dependency webpack to v5.73.0 (redwoodjs#5755) docs: update disable api layer/database to include disabling prisma (redwoodjs#5528) Fix typo in testing docs (redwoodjs#5782) fix typo (redwoodjs#5777) docs: Replacing Prisma.xxx types with types from 'types/graphql' (redwoodjs#5740) Reorganize auth docs into sub-categories (redwoodjs#5787)
Changed the TS code for the posts service to use QueryResolvers and MutationResolvers types from 'types/graphql'? The current documentation uses Prisma.xxx types like so:
But as I was following along with the tutorial, I found that the code generated by redwood for the posts service was using the types from 'types/graphql' like so:
(Made this change in side-quest.md and saving-data.md)