Maps JSON GraphQL Scalars to Prisma Json field types for compatibility #5796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for redwoodjs-docs canceled.
|
dac09
approved these changes
Jun 21, 2022
dac09
added a commit
to dac09/redwood
that referenced
this pull request
Jun 23, 2022
…ctmode-gen * 'main' of github.com:redwoodjs/redwood: validateUniquess optional prismaClient parameter (redwoodjs#5763) fix(deps): update dependency prettier to v2.7.1 (redwoodjs#5808) fix(deps): update dependency eslint to v8.18.0 (redwoodjs#5806) fix(deps): update dependency systeminformation to v5.11.21 (redwoodjs#5805) fix(deps): update dependency @apollo/client to v3.6.9 (redwoodjs#5804) chore(deps): update dependency firebase to v9.8.3 (redwoodjs#5799) Add Azure AD B2C auth provider compatibility (redwoodjs#5781) chore(deps): update dependency esbuild to v0.14.47 (redwoodjs#5798) Maps JSON GraphQL Scalars to Prisma Json field types for compatibility (redwoodjs#5796) fix(deps): update prisma monorepo to v3.15.2 (redwoodjs#5789) fix(deps): update dependency core-js to v3.23.2 (redwoodjs#5790) fix(deps): update dependency webpack to v5.73.0 (redwoodjs#5755) docs: update disable api layer/database to include disabling prisma (redwoodjs#5528) Fix typo in testing docs (redwoodjs#5782) fix typo (redwoodjs#5777) docs: Replacing Prisma.xxx types with types from 'types/graphql' (redwoodjs#5740) Reorganize auth docs into sub-categories (redwoodjs#5787)
|
@dthyresson I've found an issue with the change we made here. I think we'll need to tweak how we do this slightly It looks like it tries to add the Prisma namespace as a mapped type here, because we configure it in the type mappers: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5667
For an example of how the JSON scalar used in the SDL causes a type incompatibility with Prisma, see #5667
In Prisma, the Json field supports a few additional types, such as string and boolean. These additional types exist to match the types supported by JSON.parse().
This PR imports
Prismaand maps