Files that end with Cell are not considered Cells if they have a default export.
#597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This implementation is different from what we talked about here and also is inconsistent depending on the order of imports. If someone exports any of the expected names before exporting the default the plugin will still transform it into a cell. I'll open a PR to your branch fixing it, if you feel like accepting. |
|
Thanks @gfpacheco, I would be happy to accept those fixes. |
…t-export Fix cell plugin not handling default and named export
gfpacheco
reviewed
May 27, 2020
gfpacheco
approved these changes
May 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.