-
Notifications
You must be signed in to change notification settings - Fork 984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update scaffold css to use semantic classes #611
Update scaffold css to use semantic classes #611
Conversation
Since everything is now prefixed with |
Hmm, yeah. I'd certainly rather not need it. My concern is that the scaffold.css file is imported along with index.css in web's root index.js file, so they'll compete in the cascade. Without a mother class to contain scaffold only styles, it will be difficult to style html elements directly without a concern for conflicts with index.css. In other words, Thoughts? |
Ahhh yes, I see you have styles like:
Do you like that technique better than adding something like a Right now you've kind of got a mix of "all tags of this type" and "only tags with this class" like Whenever I think too much about CSS naming paradigms like this I get frozen with indecision... there's no way to please everyone! I think that's why for my own projects I've gone all in on Tailwind, no more worrying about problems like this. 😅 |
Oh boy, yes, I battle my own indecisiveness all day and every day. Actually, I think it's the right move to create classes for every element here so long as they are sensible (like .re-link). In the final review stages, we should probably take extra care to think about my class names—be sure they make the most sense. Anyhow, I'll do this and see how it fits. Thanks @cannikin ! |
packages/cli/src/commands/generate/scaffold/templates/assets/scaffold.css.template
Outdated
Show resolved
Hide resolved
fixup! update scaffold css to use semantic classes fixup! update scaffold css to use semantic classes fixup! update scaffold css to use semantic classes update scaffold components to use semantic classes fixup! update scaffold css to use semantic classes fixup! update scaffold components to use semantic classes fixup! update scaffold components to use semantic classes
TODO
|
packages/cli/src/commands/generate/scaffold/__tests__/fixtures/components/form.js
Outdated
Show resolved
Hide resolved
Thanks so much! |
Update scaffold css to use semantic classes - WIP!!
Closes #610