Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve typing on generated storybook components #6226

Merged
merged 17 commits into from
Aug 26, 2022
Merged

Improve typing on generated storybook components #6226

merged 17 commits into from
Aug 26, 2022

Commits on Aug 17, 2022

  1. Add type assertion to generated story

    @will-ks
    will-ks committed Aug 17, 2022
    Configuration menu
    Copy the full SHA
    ec3bca6 View commit details
    Browse the repository at this point in the history

  2. Add component property to generated story metadata

    @will-ks
    will-ks committed Aug 17, 2022
    Configuration menu
    Copy the full SHA
    fcfacbb View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2022

  1. Add type assetions and set component property for cell, layout and pa… 

    …ge stories
    @will-ks
    will-ks committed Aug 18, 2022
    Configuration menu
    Copy the full SHA
    e0cf772 View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2022

  1. Use ComponentStory type instead of Story

    @will-ks
    will-ks committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    6a0e9ef View commit details
    Browse the repository at this point in the history

  2. Regenerate stories in fixture

    @dac09
    dac09 committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    3aa9c44 View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2022

  1. Merge branch 'main' into feat/story-types

    @jtoar
    jtoar committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    11230ce View commit details
    Browse the repository at this point in the history

  2. fix: update snapshots

    @jtoar
    jtoar committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    1718499 View commit details
    Browse the repository at this point in the history

  3. handle args cases in templates 

    - cell -> loading / empty, don't pass args
- component -> explain args
- page -> only pass args to route params page
    @jtoar
    jtoar committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    a138f50 View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2022

  1. Update packages/cli/src/commands/generate/component/component.js 

    Co-authored-by: Tobbe Lundberg <tobbe@tlundberg.com>
    @jtoar @Tobbe
    jtoar and Tobbe committed Aug 26, 2022
    Configuration menu
    Copy the full SHA
    6683c56 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into feat/story-types

    @jtoar
    jtoar committed Aug 26, 2022
    Configuration menu
    Copy the full SHA
    73cd580 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into feat/story-types

    @jtoar
    jtoar committed Aug 26, 2022
    Configuration menu
    Copy the full SHA
    39e47c7 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into feat/story-types

    @jtoar
    jtoar committed Aug 26, 2022
    Configuration menu
    Copy the full SHA
    dfd2e56 View commit details
    Browse the repository at this point in the history

  5. try smoke test fix 

    see https://github.com/redwoodjs/redwood/pull/6228/files#r951763915
    @jtoar
    jtoar committed Aug 26, 2022
    Configuration menu
    Copy the full SHA
    544718c View commit details
    Browse the repository at this point in the history

  6. remove args from replace target str

    @jtoar
    jtoar committed Aug 26, 2022
    Configuration menu
    Copy the full SHA
    82ec512 View commit details
    Browse the repository at this point in the history

  7. Revert "try smoke test fix" 

    This reverts commit 544718c.
    @jtoar
    jtoar committed Aug 26, 2022
    Configuration menu
    Copy the full SHA
    003886c View commit details
    Browse the repository at this point in the history

  8. Merge branch 'main' into feat/story-types

    @jtoar
    jtoar committed Aug 26, 2022
    Configuration menu
    Copy the full SHA
    01cdd4c View commit details
    Browse the repository at this point in the history

  9. Merge branch 'main' into feat/story-types

    @Tobbe
    Tobbe committed Aug 26, 2022
    Configuration menu
    Copy the full SHA
    6aa45c3 View commit details
    Browse the repository at this point in the history