Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency esbuild to v0.17.13 #7915

Merged
merged 2 commits into from Mar 24, 2023
Merged

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Mar 24, 2023

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
esbuild 0.17.12 -> 0.17.13 age adoption passing confidence

Release Notes

evanw/esbuild

v0.17.13

Compare Source

  • Work around an issue with NODE_PATH and Go's WebAssembly internals (#​3001)

    Go's WebAssembly implementation returns EINVAL instead of ENOTDIR when using the readdir syscall on a file. This messes up esbuild's implementation of node's module resolution algorithm since encountering ENOTDIR causes esbuild to continue its search (since it's a normal condition) while other encountering other errors causes esbuild to fail with an I/O error (since it's an unexpected condition). You can encounter this issue in practice if you use node's legacy NODE_PATH feature to tell esbuild to resolve node modules in a custom directory that was not installed by npm. This release works around this problem by converting EINVAL into ENOTDIR for the readdir syscall.

  • Fix a minification bug with CSS @layer rules that have parsing errors (#​3016)

    CSS at-rules require either a {} block or a semicolon at the end. Omitting both of these causes esbuild to treat the rule as an unknown at-rule. Previous releases of esbuild had a bug that incorrectly removed unknown at-rules without any children during minification if the at-rule token matched an at-rule that esbuild can handle. Specifically cssnano can generate @layer rules with parsing errors, and empty @layer rules cannot be removed because they have side effects (@layer didn't exist when esbuild's CSS support was added, so esbuild wasn't written to handle this). This release changes esbuild to no longer discard @layer rules with parsing errors when minifying (the rule @layer c has a parsing error):

    /* Original input */
    @​layer a {
      @​layer b {
        @​layer c
      }
    }
    
    /* Old output (with --minify) */
    @​layer a.b;
    
    /* New output (with --minify) */
    @​layer a.b.c;
  • Unterminated strings in CSS are no longer an error

    The CSS specification provides rules for handling parsing errors. One of those rules is that user agents must close strings upon reaching the end of a line (i.e., before an unescaped line feed, carriage return or form feed character), but then drop the construct (declaration or rule) in which the string was found. For example:

    p {
      color: green;
      font-family: 'Courier New Times
      color: red;
      color: green;
    }

    ...would be treated the same as:

    p { color: green; color: green; }

    ...because the second declaration (from font-family to the semicolon after color: red) is invalid and is dropped.

    Previously using this CSS with esbuild failed to build due to a syntax error, even though the code can be interpreted by a browser. With this release, the code now produces a warning instead of an error, and esbuild prints the invalid CSS such that it stays invalid in the output:

    /* esbuild's new non-minified output: */
    p {
      color: green;
      font-family: 'Courier New Times
      color: red;
      color: green;
    }
    /* esbuild's new minified output: */
    p{font-family:'Courier New Times
    color: red;color:green}

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added the release:chore This PR is a chore (means nothing for users) label Mar 24, 2023
@replay-io
Copy link

replay-io bot commented Mar 24, 2023

16 replays were recorded for df1a300.

image 0 Failed
image 16 Passed
    requireAuth graphql checks
          ```
          locator.waitFor: Target closed
          =========================== logs ===========================
          waiting for locator('.rw-form-error-title').locator('text=You don\'t have permission to do that') to be visible
          ============================================================
          ```
        </ol>
      </details>
      <li><a href=https://app.replay.io/recording/baec3f7b-90ed-4e03-a2a2-bb5913335b99>useAuth hook, auth redirects checks</a></li>
      <li><a href=https://app.replay.io/recording/ae767999-c858-441a-ad81-f57a5f5e9000>Check that a specific blog post is prerendered</a></li>
      <li><a href=https://app.replay.io/recording/f726ff5d-54fb-485f-8c59-7556e9792cdf>Check that about is prerendered</a></li>
      <li><a href=https://app.replay.io/recording/f66df46c-b365-4208-9327-7a86ff9f9c3e>Check that homepage is prerendered</a></li>
      <li><a href=https://app.replay.io/recording/6978ed95-e3f0-4fc6-94e5-6faeb986c211>Check that meta-tags are rendering the correct dynamic data</a></li>
      <li><a href=https://app.replay.io/recording/5ff1364b-4dda-4610-803b-c6b62146cbe7>Check that you can navigate from home page to specific blog post</a></li>
      <li><a href=https://app.replay.io/recording/213a3da5-a182-4c57-8d17-f537d114c490>Waterfall prerendering (nested cells)</a></li>
      <li><a href=https://app.replay.io/recording/e17f3468-3038-41e2-9fb4-7c837d31a2ab>RBAC: Admin user should be able to delete contacts</a></li>
      <li><a href=https://app.replay.io/recording/b751fb9b-bed2-4b8f-8bf8-92b3f3a2138c>RBAC: Should not be able to delete contact as non-admin user</a></li>
      <li><a href=https://app.replay.io/recording/f708f278-7722-4c8a-bd2e-7930210b420f>Smoke test with dev server</a></li>
      <li><a href=https://app.replay.io/recording/0ee89154-c8b0-4176-a133-b6bba0e18e8e>Smoke test with rw serve</a></li>
      <li><a href=https://app.replay.io/recording/d735f9aa-a108-4935-a1ab-8ddc0a5641cf>Loads Cell mocks when Cell is nested in another story</a></li>
      <li><a href=https://app.replay.io/recording/c0f257d5-aaf5-4865-a10f-021c592bf071>Loads Cell Stories</a></li>
      <li><a href=https://app.replay.io/recording/c6838ce6-c89a-406e-bd02-7492d72a4c0f>Loads MDX Stories</a></li>
      <li><a href=https://app.replay.io/recording/72313355-4511-4146-913b-505dc453331d>Mocks current user, and updates UI while dev server is running</a></li>
      

View test run on Replay ↗︎

@jtoar jtoar merged commit c2ba5f0 into main Mar 24, 2023
8 of 9 checks passed
@jtoar jtoar deleted the renovate/esbuild-0.x branch March 24, 2023 23:19
@redwoodjs-bot redwoodjs-bot bot added this to the next-release milestone Mar 24, 2023
@jtoar jtoar modified the milestones: next-release, v5.0.0 Mar 27, 2023
dac09 added a commit to dac09/redwood that referenced this pull request Mar 28, 2023
* 'main' of github.com:redwoodjs/redwood: (162 commits)
  fix(deps): update dependency @escape.tech/graphql-armor to v1.8.0 (redwoodjs#7922)
  chore(deps): update dependency @playwright/test to v1.32.1 (redwoodjs#7924)
  chore(deps): update dependency @testing-library/dom to v9.2.0 (redwoodjs#7921)
  chore(deps): update dependency rimraf to v4 (redwoodjs#7907)
  fix(deps): update dependency react-hook-form to v7.43.8 (redwoodjs#7920)
  fix(deps): update dependency @fastify/http-proxy to v9 (redwoodjs#7889)
  fix(deps): update dependency @types/node to v16.18.20 (redwoodjs#7919)
  chore(deps): update dependency @replayio/playwright to v0.3.27 (redwoodjs#7918)
  fix(Clerk): call reauthenticate before navigating (redwoodjs#7917)
  chore(deps): update dependency esbuild to v0.17.13 (redwoodjs#7915)
  chore(deps): update dependency lerna to v6.6.1 (redwoodjs#7916)
  chore(deps): update dependency @tsd/typescript to v5 (redwoodjs#7856)
  chore(deps): update dependency @testing-library/dom to v9.1.0 (redwoodjs#7914)
  fix(deps): update dependency msw to v1.2.1 (redwoodjs#7911)
  chore(deps): update dependency @types/react to v18.0.29 (redwoodjs#7912)
  chore(deps): update dependency nx to v15.8.9 (redwoodjs#7913)
  Fix for directUrl usage during testing (redwoodjs#7898)
  fix(deps): update dependency prettier to v2.8.7 (redwoodjs#7908)
  chore(deps): update dependency @nrwl/nx-cloud to v15.3.2 (redwoodjs#7904)
  fix(deps): update dependency @types/node to v16.18.19 (redwoodjs#7906)
  ...
@jtoar jtoar modified the milestones: next-release, v4.5.0 Apr 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:chore This PR is a chore (means nothing for users)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant