Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(coherence deploy): add setup deploy coherence #8234

Merged
merged 14 commits into from
May 17, 2023

Conversation

jtoar
Copy link
Contributor

@jtoar jtoar commented May 5, 2023

This PR is take-two of adding Coherence to Redwood's list of supported deploy providers.

@zach-withcoherence and I just got it working in deploy target CI. There's a few things we have to figure out, but since we've gotten it working once, re-opening this PR now to keep track of the remaining tasks:

  • what's the correct migration command? yarn rw prisma migrate dev? yarn rw prisma migrate deploy? we also have to make sure seeding works as expected
    • from prisma's docs, migrate deploy is definitely what we want. but does it run seed? and what about data migrations?
  • add logic for adding adapter: postgresql to the coherence.yml template if the database is postgresql.
    • do we need an adapter for mysql as well?
  • --no-prerender is still necessary on the first deploy because the database ready. we have to handle this through docs at the moment

@jtoar jtoar added the release:feature This PR introduces a new feature label May 5, 2023
@jtoar jtoar added the fixture-ok Override the test project fixture check label May 6, 2023
@jtoar jtoar marked this pull request as ready for review May 15, 2023 20:16
docs/docs/deploy/coherence.md Outdated Show resolved Hide resolved
@jtoar jtoar merged commit de8b0fa into main May 17, 2023
23 checks passed
@jtoar jtoar deleted the ds-coherence/add-back-coherence-deploy branch May 17, 2023 21:51
@redwoodjs-bot redwoodjs-bot bot added this to the next-release milestone May 17, 2023
jtoar added a commit that referenced this pull request May 17, 2023
* feat: add setup deploy coherence

* add changes to yaml template

* Update packages/cli/src/commands/setup/deploy/providers/coherenceHandler.js

* warn on prerender, style

* add warning to docs

* properly escape quotes

* configure toml

* throw instead of warn

* style: move notes inline

* properly try-catch

* add to intro

* add note about data migrations
@jtoar jtoar modified the milestones: next-release, v5.2.0 May 17, 2023
dac09 added a commit to dac09/redwood that referenced this pull request May 19, 2023
…te-default

* 'main' of github.com:redwoodjs/redwood: (23 commits)
  chore(deps): update dependency @clerk/clerk-react to v4.16.2 (redwoodjs#8362)
  chore(package size): implement `findup-sync` in `@redwoodjs/project-config` (redwoodjs#8315)
  Refactor GraphQL Server and CreateYoga to Support "api serve" with Fastify Server (redwoodjs#8339)
  chore(deps): update dependency octokit to v2.0.15 (redwoodjs#8360)
  fix(coherence): correct doc links, add commas to template (redwoodjs#8351)
  Parse as int, fix jsdoc (redwoodjs#8357)
  Update forms.md (redwoodjs#8352)
  chore: update yarn.lock
  chore(release): update release command for minors
  chore(deps): update dependency rimraf to v5.0.1 (redwoodjs#8350)
  chore(deps): update dependency glob to v10.2.5 (redwoodjs#8349)
  feat(coherence deploy): add setup deploy coherence (redwoodjs#8234)
  fix(deps): update dependency listr2 to v6.6.0 (redwoodjs#8347)
  fix(deps): update dependency react-router-dom to v6.11.2 (redwoodjs#8345)
  fix(deps): update prisma monorepo to v4.14.1 (redwoodjs#8346)
  fix(deps): update dependency webpack to v5.83.1 (redwoodjs#8348)
  chore(deps): update dependency dependency-cruiser to v13 (redwoodjs#8322)
  chore(deps): update dependency @clerk/clerk-react to v4.16.1 (redwoodjs#8324)
  chore(deps): update dependency @clerk/types to v3.38.0 (redwoodjs#8325)
  chore(deps): update dependency nx to v16.2.1 (redwoodjs#8343)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixture-ok Override the test project fixture check release:feature This PR introduces a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant