-
Notifications
You must be signed in to change notification settings - Fork 975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(package size): implement findup-sync
in @redwoodjs/project-config
#8315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@jtoar aside from package size (which I agree is critical for our needs), how else are you evaluating |
|
findup-sync
for look-it-up
findup-sync
in @redwoodjs/project-config
thedavidprice
approved these changes
May 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woah, you tidied things up all over the place. Thank you for choosing this implementation. Definitely feels worth the effort!
dac09
added a commit
to dac09/redwood
that referenced
this pull request
May 19, 2023
…te-default * 'main' of github.com:redwoodjs/redwood: (23 commits) chore(deps): update dependency @clerk/clerk-react to v4.16.2 (redwoodjs#8362) chore(package size): implement `findup-sync` in `@redwoodjs/project-config` (redwoodjs#8315) Refactor GraphQL Server and CreateYoga to Support "api serve" with Fastify Server (redwoodjs#8339) chore(deps): update dependency octokit to v2.0.15 (redwoodjs#8360) fix(coherence): correct doc links, add commas to template (redwoodjs#8351) Parse as int, fix jsdoc (redwoodjs#8357) Update forms.md (redwoodjs#8352) chore: update yarn.lock chore(release): update release command for minors chore(deps): update dependency rimraf to v5.0.1 (redwoodjs#8350) chore(deps): update dependency glob to v10.2.5 (redwoodjs#8349) feat(coherence deploy): add setup deploy coherence (redwoodjs#8234) fix(deps): update dependency listr2 to v6.6.0 (redwoodjs#8347) fix(deps): update dependency react-router-dom to v6.11.2 (redwoodjs#8345) fix(deps): update prisma monorepo to v4.14.1 (redwoodjs#8346) fix(deps): update dependency webpack to v5.83.1 (redwoodjs#8348) chore(deps): update dependency dependency-cruiser to v13 (redwoodjs#8322) chore(deps): update dependency @clerk/clerk-react to v4.16.1 (redwoodjs#8324) chore(deps): update dependency @clerk/types to v3.38.0 (redwoodjs#8325) chore(deps): update dependency nx to v16.2.1 (redwoodjs#8343) ...
jtoar
added a commit
that referenced
this pull request
May 19, 2023
…onfig` (#8315) * chore: swap out findup-sync for lighter alt * cli * rest * update readme * update dep graphs * fix lint * swap external package for our own * follow-up fixes * fix eslint fn * update dep cruiser to 13 * lint fix
jtoar
added a commit
that referenced
this pull request
Jun 2, 2023
…onfig` (#8315) * chore: swap out findup-sync for lighter alt * cli * rest * update readme * update dep graphs * fix lint * swap external package for our own * follow-up fixes * fix eslint fn * update dep cruiser to 13 * lint fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
findup-sync
isn't huge, but it's much bigger than it needs to be for our purposes. Let's get rid of it for our own custom implementation that's less generic but get the the job done, and continue chipping away at@redwoodjs/project-config
's size till it's only as big as it needs to be.findup-sync
's package size stats: (courtesy of https://packagephobia.com/result?p=findup-sync)This PR adds a new function to
@redwoodjs/project-config
,findUp
, which looks up directories for a file:redwood/packages/project-config/src/findUp.ts
Lines 1 to 25 in f3b5882
It's as simple as it needs to be. It doesn't need to be more generic (i.e. take a function); doesn't need to be async, etc. It just needs to find
redwood.toml
.This PR includes a lot of changes because I removed
findup-sync
everywhere I could. One of those places is the codemods package. SincefindUp
lives in@redwoodjs/project-config
, I had to add it as a dependency, but this is a good thing because now I can get rid of the needless duplication in the codemods package.