chore(package size): implement findup-sync in @redwoodjs/project-config

[jtoar]

Note

I'm ok with adding a new function to @redwoodjs/project-config because it needs it. But I'm not intending for @redwoodjs/project-config to become a package where utilities go.

findup-sync isn't huge, but it's much bigger than it needs to be for our purposes. Let's get rid of it for our own custom implementation that's less generic but get the the job done, and continue chipping away at @redwoodjs/project-config's size till it's only as big as it needs to be.

findup-sync's package size stats: (courtesy of https://packagephobia.com/result?p=findup-sync)

publish size	install size
7.62 kB	374 kB

This PR adds a new function to @redwoodjs/project-config, findUp, which looks up directories for a file:

redwood/packages/project-config/src/findUp.ts

Lines 1 to 25 in f3b5882

	import fs from 'fs'
	import path from 'path'
	/**
	* Find a file by walking up parent directories.
	*/
	export function findUp(
	file: string,
	startingDirectory: string = process.cwd()
	): string | null {
	const possibleFilepath = path.join(startingDirectory, file)
	if (fs.existsSync(possibleFilepath)) {
	return possibleFilepath
	}
	const parentDirectory = path.dirname(startingDirectory)
	// If we've reached the root directory, there's no file to be found.
	if (parentDirectory === startingDirectory) {
	return null
	}
	return findUp(file, parentDirectory)
	}

It's as simple as it needs to be. It doesn't need to be more generic (i.e. take a function); doesn't need to be async, etc. It just needs to find redwood.toml.

This PR includes a lot of changes because I removed findup-sync everywhere I could. One of those places is the codemods package. Since findUp lives in @redwoodjs/project-config, I had to add it as a dependency, but this is a good thing because now I can get rid of the needless duplication in the codemods package.

[replay-io]

19 replays were recorded for 4895605.

0 Failed

19 Passed

• requireAuth graphql checks

  locator.waitFor: Target closed
  =========================== logs ===========================
  waiting for locator('.rw-form-error-title').locator('text=You don\'t have permission to do that') to be visible
  ============================================================

• useAuth hook, auth redirects checks
• Check that a specific blog post is prerendered
• Check that about is prerendered
• Check that homepage is prerendered
• Check that meta-tags are rendering the correct dynamic data
• Check that rehydration works for page not wrapped in Set
• Check that rehydration works for page with Cell in Set
• Check that rehydration works for page with code split chunks
• Check that you can navigate from home page to specific blog post
• Waterfall prerendering (nested cells)
• RBAC: Admin user should be able to delete contacts
• RBAC: Should not be able to delete contact as non-admin user
• Smoke test with dev server
• Smoke test with rw serve
• Loads Cell mocks when Cell is nested in another story
• Loads Cell Stories
• Loads MDX Stories
• Mocks current user, and updates UI while dev server is running

View test run on Replay ↗︎

[thedavidprice]

@jtoar aside from package size (which I agree is critical for our needs), how else are you evaluating look-it-up as a stable package?

[jtoar]

@thedavidprice

• it passes our tests
• reading the source, looking at its package.json; general stats about the repo like how many issues, time to close, commits, etc. But most of that is ancillary to just looking at what it actually does

[thedavidprice]

Woah, you tidied things up all over the place. Thank you for choosing this implementation. Definitely feels worth the effort!