jest: increase cli test timeout #845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ha! I love that you split the distance 😉 I'm all for this. My only concern is potentially adding more time to the CI runners. But in my experience this has been caused by slow processors and not errors. @peterp looping you in for a final say 'cause I don't know what I don't know. |
Yeah, I had to. 10 sec wasn't enough for the tests to pass on my machine
We don't have any tests that rely on the timeout do we? As long as we don't, this should only ever affect things when we have failing test cases. As long as all tests are passing the execution time shouldn't change |
peterp
approved these changes
Jul 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #838