Move fastify.logger.infos to fastify.logger.traces #8590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtoar
approved these changes
Jun 12, 2023
There was a problem hiding this comment.
Thanks @orta, this is definitely an improvement! I'm going to mark this is as breaking for now just to be safe till I run it by @thedavidprice; we made similar logger changes for the better in #8353 and marked it as breaking out of an abundance of caution
dac09
added a commit
to dac09/redwood
that referenced
this pull request
Jun 13, 2023
…into chore/rename-entry-client * 'chore/rename-entry-client' of github.com:dac09/redwood: Move fastify.logger.infos to fastify.logger.traces (redwoodjs#8590) Make the fastify logger respect the LOG_LEVEL value set in the env (redwoodjs#8588) feat: Update the SDL types lib (redwoodjs#8586) Fix the codegen path for the GraphQL context objcet (redwoodjs#8585) chore(deps): update dependency @clerk/types to v3.42.0 (redwoodjs#8584) feat(codemod): Add codemod for js to jsx conversion (redwoodjs#8551)
jtoar
reviewed
Jun 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default experience of
yarn devlets you know a bunch of stuff you don't really care about WRT fastify (e.g. I've never once cared about what plugins are installed, but it fills my terminal)This moves them all (and the templated files) to use trace so that they are opt-in when you want to know about those sort of internal details - pairs with #8588