fix: Insert const in for...of loop #8732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tobbe
approved these changes
Jun 25, 2023
|
@drikusroor Thanks for the fix! 🙂 Just need to take care of our test project too. |
Thanks, I overlooked that one indeed! |
We all do. That's why we added a CI job to check it for us 😅 |
jtoar
pushed a commit
that referenced
this pull request
Jun 27, 2023
* fix: Insert const in for...of loop See also: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/for...of * fix: Insert const in for...of loop in test-project as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I uncommented those lines (41-58 in
seed.ts) as I wanted to create some users in my seeder and it didn't work as expected. After inserting thatconstbeforeuser, everything worked according to plan. It's also according to thefor...ofdocs as far as I know.Perhaps it would have been fine in old school javascript or in coffeescript, but I don't think y'all are aiming for that 😊