Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli(fix): Stop storybook command installing early #8828

Merged
merged 7 commits into from
Jul 6, 2023

Conversation

Josh-Walker-GM
Copy link
Collaborator

Problem
The current CLI plugin system would attempt to install storybook when you reached the help screen.

Changes

  1. Reworks when the plugin logic will provide default entries and now provides default entries for all redwood commands that come from different packages.
  2. Reworks the default plugin information cache to include the aliases and description.

@Josh-Walker-GM Josh-Walker-GM added the release:fix This PR is a fix label Jul 5, 2023
@Josh-Walker-GM Josh-Walker-GM added this to the v6.0.0 milestone Jul 5, 2023
@Josh-Walker-GM Josh-Walker-GM requested a review from jtoar July 5, 2023 18:40
@Josh-Walker-GM Josh-Walker-GM changed the title cli(fix): Storybook command installing early cli(fix): Stop storybook command installing early Jul 5, 2023
@Josh-Walker-GM Josh-Walker-GM removed the request for review from jtoar July 6, 2023 15:05
@Josh-Walker-GM Josh-Walker-GM enabled auto-merge (squash) July 6, 2023 18:18
@Josh-Walker-GM Josh-Walker-GM merged commit bca98c6 into main Jul 6, 2023
29 checks passed
@Josh-Walker-GM Josh-Walker-GM deleted the jgmw-cli/fix-aggressive-storybook-install branch July 6, 2023 18:19
jtoar pushed a commit that referenced this pull request Jul 6, 2023
**Problem**
The current CLI plugin system would attempt to install storybook when
you reached the help screen.

**Changes**
1. Reworks when the plugin logic will provide default entries and now
provides default entries for all redwood commands that come from
different packages.
2. Reworks the default plugin information cache to include the aliases
and description.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:fix This PR is a fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants