fix(server): don't mix async and callback styles #9931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtoar
force-pushed
the
ds-server/dont-mix-async-and-cb-styles
branch
from
d49e39b
to
6d91c2c
Compare
jtoar
added a commit
that referenced
this pull request
Jan 29, 2024
Running `yarn rw serve` in the v7 RC emits two warnings:
```
$ yarn rw serve
...
(node:69556) [FSTWRN002] FastifyWarning: The redwoodFastifyWeb plugin being registered mixes async and callback styles, which will result in an error in `fastify@5`
(Use `node --trace-warnings ...` to show where the warning was created)
(node:69556) [FSTWRN002] FastifyWarning: The redwoodFastifyAPI plugin being registered mixes async and callback styles, which will result in an error in `fastify@5`
```
These seem to be because the fastify plugins are async but use the
`done` param, which is the callback style. This PR removes the callback
style in favor of the async.
I'm also removing this warn log which we've already handled on the
frontend by registering a warning route for. Right now there's no
correct configuration for it when both plugins are registered on the
same instance, which is what we've been doing since forever, and I don't
want logs to become meaningless:
```
{"level":40,"time":1706557821043,"pid":69556,"hostname":"evaM1.local","msg":"apiUrl is relative but there's no proxy target"}
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running
yarn rw servein the v7 RC emits two warnings:These seem to be because the fastify plugins are async but use the
doneparam, which is the callback style. This PR removes the callback style in favor of the async.I'm also removing this warn log which we've already handled on the frontend by registering a warning route for. Right now there's no correct configuration for it when both plugins are registered on the same instance, which is what we've been doing since forever, and I don't want logs to become meaningless: