Skip to content
This repository has been archived by the owner on Aug 16, 2022. It is now read-only.

feat: create installable plugins #1

Merged
merged 6 commits into from Jun 18, 2021
Merged

feat: create installable plugins #1

merged 6 commits into from Jun 18, 2021

Conversation

mimoham24
Copy link
Contributor

@mimoham24 mimoham24 commented May 10, 2021

No description provided.

@mimoham24 mimoham24 requested a review from rot1024 May 10, 2021 20:13
yk-eukarya and others added 3 commits June 2, 2021 11:56
* - comment out unused code

* - add test data

* - reader test

* - sequential reader test

* - shp type test

* - shp test

* - writer test

* - zip reader test

* - add test data

* fix PR comments

Co-authored-by: YK <ykeukarya@gmail.com>
* - comment out unused code

* - add test data

* - reader test

* - sequential reader test

* - shp type test

* - shp test

* - writer test

* - zip reader test

* - add test data

* fix PR comments
@codecov
Copy link

codecov bot commented Jun 2, 2021

Codecov Report

Merging #1 (c0293ff) into main (ef75dd0) will increase coverage by 0.05%.
The diff coverage is 73.07%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main       #1      +/-   ##
==========================================
+ Coverage   45.79%   45.84%   +0.05%     
==========================================
  Files         176      178       +2     
  Lines       13848    13874      +26     
==========================================
+ Hits         6342     6361      +19     
- Misses       6540     6547       +7     
  Partials      966      966              
Impacted Files Coverage Δ
internal/usecase/interactor/plugin.go 0.00% <0.00%> (ø)
internal/infrastructure/github/fetcher.go 100.00% <100.00%> (ø)
internal/infrastructure/github/plugin_registry.go 100.00% <100.00%> (ø)

@mimoham24 mimoham24 requested review from HideBa and KaWaite June 15, 2021 07:37
Copy link
Member

@rot1024 rot1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot posting pending comments. Sorry

internal/usecase/gateway/container.go Outdated Show resolved Hide resolved
internal/usecase/gateway/plugin_registry.go Outdated Show resolved Hide resolved
@mimoham24 mimoham24 requested a review from rot1024 June 15, 2021 09:14
Copy link
Member

@HideBa HideBa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mimoham24 mimoham24 merged commit 5b7a5fd into main Jun 18, 2021
@mimoham24 mimoham24 deleted the plugin-metadata branch June 18, 2021 11:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
4 participants