This repository has been archived by the owner on Aug 16, 2022. It is now read-only.
test: pkg/shp #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yk-eukarya
requested review from
mimoham24 and
rot1024
and removed request for
mimoham24 and
rot1024
rot1024
suggested changes
May 31, 2021
Codecov Report
@@ Coverage Diff @@
## main #5 +/- ##
==========================================
+ Coverage 36.25% 37.03% +0.78%
==========================================
Files 169 176 +7
Lines 12973 13800 +827
==========================================
+ Hits 4703 5111 +408
- Misses 7669 7899 +230
- Partials 601 790 +189
|
rot1024
approved these changes
Jun 1, 2021
mimoham24
pushed a commit
that referenced
this pull request
Jun 2, 2021
* - comment out unused code * - add test data * - reader test * - sequential reader test * - shp type test * - shp test * - writer test * - zip reader test * - add test data * fix PR comments Co-authored-by: YK <ykeukarya@gmail.com>
mimoham24
approved these changes
Jun 2, 2021
rot1024
pushed a commit
that referenced
this pull request
Jun 3, 2021
* - comment out unused code * - add test data * - reader test * - sequential reader test * - shp type test * - shp test * - writer test * - zip reader test * - add test data * fix PR comments Co-authored-by: YK <ykeukarya@gmail.com>
yk-eukarya
added a commit
that referenced
this pull request
Jun 8, 2021
* testing pkg/id/id.go * testing pkg/id/plugin.go * testing pkg/id/plugin.go * testing pkg/id/plugin_extension.go * testing pkg/id/property_schema.go * testing pkg/id/property_schema_field.go * testing id.tmpl * reduce some duplicated logic * - update gen.go file - uncomment some test cases * fix PR comments * test: pkg/shp (#5) * - comment out unused code * - add test data * - reader test * - sequential reader test * - shp type test * - shp test * - writer test * - zip reader test * - add test data * fix PR comments Co-authored-by: YK <ykeukarya@gmail.com> * test: pkg/shp (#5) * - comment out unused code * - add test data * - reader test * - sequential reader test * - shp type test * - shp test * - writer test * - zip reader test * - add test data * fix PR comments Co-authored-by: YK <ykeukarya@gmail.com> Co-authored-by: rot1024 <aayhrot@gmail.com>
mimoham24
added a commit
that referenced
this pull request
Jun 18, 2021
* clone install-plugin branch to oss * test: pkg/shp (#5) * - comment out unused code * - add test data * - reader test * - sequential reader test * - shp type test * - shp test * - writer test * - zip reader test * - add test data * fix PR comments Co-authored-by: YK <ykeukarya@gmail.com> * test: pkg/shp (#5) * - comment out unused code * - add test data * - reader test * - sequential reader test * - shp type test * - shp test * - writer test * - zip reader test * - add test data * fix PR comments * resolve comments Co-authored-by: yk-eukarya <81808708+yk-eukarya@users.noreply.github.com> Co-authored-by: YK <ykeukarya@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.