Skip to content
This repository has been archived by the owner on Aug 16, 2022. It is now read-only.

test: pkg/id #4

Merged
merged 16 commits into from Jun 8, 2021
Merged

test: pkg/id #4

merged 16 commits into from Jun 8, 2021

Conversation

yk-eukarya
Copy link
Contributor

No description provided.

@yk-eukarya yk-eukarya self-assigned this May 18, 2021
@yk-eukarya yk-eukarya requested a review from mimoham24 May 19, 2021 08:56
pkg/id/id_test.go Show resolved Hide resolved
pkg/id/id_test.go Outdated Show resolved Hide resolved
pkg/id/id_test.go Outdated Show resolved Hide resolved
pkg/id/id_test.tmpl Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jun 1, 2021

Codecov Report

Merging #4 (4ffaaf8) into main (06cd446) will increase coverage by 8.75%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main       #4      +/-   ##
==========================================
+ Coverage   37.04%   45.79%   +8.75%     
==========================================
  Files         176      176              
  Lines       13824    13848      +24     
==========================================
+ Hits         5121     6342    +1221     
+ Misses       7913     6540    -1373     
- Partials      790      966     +176     
Impacted Files Coverage Δ
pkg/id/dataset_schema_field_gen.go 76.14% <66.66%> (+76.14%) ⬆️
pkg/id/infobox_field_gen.go 76.14% <66.66%> (+76.14%) ⬆️
pkg/id/plugin.go 69.49% <0.00%> (+64.40%) ⬆️
pkg/id/plugin_extension.go 71.42% <0.00%> (+71.42%) ⬆️
pkg/id/property_schema_field.go 73.33% <0.00%> (+73.33%) ⬆️
pkg/id/property_schema.go 75.00% <0.00%> (+75.00%) ⬆️
pkg/id/team_gen.go 76.14% <0.00%> (+76.14%) ⬆️
pkg/id/user_gen.go 76.14% <0.00%> (+76.14%) ⬆️
... and 10 more

eng-ymk and others added 4 commits June 2, 2021 11:44
* - comment out unused code

* - add test data

* - reader test

* - sequential reader test

* - shp type test

* - shp test

* - writer test

* - zip reader test

* - add test data

* fix PR comments

Co-authored-by: YK <ykeukarya@gmail.com>
* - comment out unused code

* - add test data

* - reader test

* - sequential reader test

* - shp type test

* - shp test

* - writer test

* - zip reader test

* - add test data

* fix PR comments
@yk-eukarya yk-eukarya requested a review from rot1024 June 4, 2021 07:25
@yk-eukarya yk-eukarya merged commit c31bdb6 into main Jun 8, 2021
@yk-eukarya yk-eukarya deleted the testing/pkg-id branch June 8, 2021 06:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
3 participants