Skip to content
This repository has been archived by the owner on Aug 16, 2022. It is now read-only.

feat: add "clamp to ground" option to file primitive #95

Merged
merged 4 commits into from
Jan 21, 2022

Conversation

HideBa
Copy link
Member

@HideBa HideBa commented Dec 27, 2021

Overview

What I've done

What I haven't done

How I tested

Which point I want you to review particularly

Memo

@codecov
Copy link

codecov bot commented Dec 27, 2021

Codecov Report

Merging #95 (d3b103c) into main (0d112c5) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #95   +/-   ##
=======================================
  Coverage   33.61%   33.61%           
=======================================
  Files         296      296           
  Lines       26608    26608           
=======================================
  Hits         8945     8945           
  Misses      16854    16854           
  Partials      809      809           

@HideBa HideBa changed the title feat: update manifest file(file's clamp field) feat: add an option "clamp to ground" to file Jan 20, 2022
@HideBa HideBa marked this pull request as ready for review January 20, 2022 01:29
pkg/builtin/manifest.yml Outdated Show resolved Hide resolved
Copy link
Member

@KaWaite KaWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated English. Check accuracy of my updated description before committing

@rot1024 rot1024 changed the title feat: add an option "clamp to ground" to file feat: add "clamp to ground" option to file primitive Jan 20, 2022
pkg/builtin/manifest_ja.yml Outdated Show resolved Hide resolved
HideBa and others added 2 commits January 21, 2022 15:01
Co-authored-by: KaWaite <34051327+KaWaite@users.noreply.github.com>
Co-authored-by: rot1024 <aayhrot@gmail.com>
@HideBa HideBa merged commit 5591948 into main Jan 21, 2022
@HideBa HideBa deleted the feat--add-"clamp"-to-file-plugin branch January 21, 2022 06:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants