Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(web): publish modal #658

Merged
merged 12 commits into from
Sep 6, 2023
Merged

chore(web): publish modal #658

merged 12 commits into from
Sep 6, 2023

Conversation

mkumbobeaty
Copy link
Contributor

Overview

Improvement in publish modal

What I've done

  • Fix error when publish project
  • improve button disable on publish/update/unpublish
  • Improve nav dropdown to display update if project is published

What I haven't done

How I tested

  • project

Which point I want you to review particularly

  • publish a project
  • unpublish a project

Memo

@netlify
Copy link

netlify bot commented Sep 4, 2023

Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit b40e219
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/64f8787ce8fe2600081ead40
😎 Deploy Preview https://deploy-preview-658--reearth-web.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the web label Sep 4, 2023
@mkumbobeaty mkumbobeaty changed the title Fix/publish modal fix(web): publish modal Sep 4, 2023
@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Merging #658 (0732fef) into main (4ee1969) will increase coverage by 0.02%.
The diff coverage is 0.00%.

❗ Current head 0732fef differs from pull request most recent head b40e219. Consider uploading reports for the commit b40e219 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #658      +/-   ##
==========================================
+ Coverage   26.81%   26.83%   +0.02%     
==========================================
  Files        1547     1545       -2     
  Lines      168710   168511     -199     
  Branches     3870     3869       -1     
==========================================
- Hits        45245    45228      -17     
+ Misses     122376   122194     -182     
  Partials     1089     1089              
Flag Coverage Δ
web 25.13% <0.00%> (+0.02%) ⬆️
web-beta 25.13% <0.00%> (+0.02%) ⬆️
web-classic 25.13% <0.00%> (+0.02%) ⬆️
web-utils 25.13% <0.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...ures/Editor/tabs/publish/Nav/PublishModal/hooks.ts 0.00% <0.00%> (ø)
...res/Editor/tabs/publish/Nav/PublishModal/index.tsx 0.00% <0.00%> (ø)
...src/beta/features/Editor/tabs/publish/Nav/hooks.ts 0.00% <0.00%> (ø)
...rc/beta/features/Editor/tabs/publish/Nav/index.tsx 0.00% <0.00%> (ø)
web/src/services/api/projectApi.ts 13.85% <0.00%> (+0.13%) ⬆️

... and 7 files with indirect coverage changes

@KaWaite KaWaite changed the title fix(web): publish modal chore(web): publish modal Sep 6, 2023
@mkumbobeaty mkumbobeaty merged commit df854f8 into main Sep 6, 2023
13 checks passed
@mkumbobeaty mkumbobeaty deleted the fix/publish-modal branch September 6, 2023 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants